[Mono-dev] Coding conventions when porting MS code.
Miguel de Icaza
miguel at xamarin.com
Sat Nov 15 16:43:50 UTC 2014
Yes, that is the idea.
But work can start without the sub module.
As for partials: it is easy, just patch the source to add partials where
On Saturday, November 15, 2014, Martin Thwaites <monoforum at my2cents.co.uk>
> So is the plan to pull the repository in as a submodule to reference the
> files? Maybe we could that part committed so we can start referencing the
> I'm not sure how a partial class approach would work (all the MS Classes
> seem to not be partials), so if you could maybe provide some examples of
> this I would be very interested.
> On 15 November 2014 14:49, Miguel de Icaza <miguel at xamarin.com
>> Most of the time we just "reference" the file, so we shouldn't make style
>> changes to it.
>> In the cases where we only bring bits, we have a spectrum of options from
>> using partial classes to having to copy-paste and only in hat case we would
>> On Saturday, November 15, 2014, Martin Thwaites <monoforum at my2cents.co.uk
>>> Hi All,
>>> I'm looking into porting some code over from the reference source, and
>>> I've noticed that it doesn't match the mono coding conventions.
>>> Things like spaces instead of tabs, no space before the opening bracket
>>> in a method call etc.
>>> They seem like minor things, so I'm curious what the stance should be?
>>> Maybe it's 2 rules? if you port the entire file without changes, it's ok
>>> to keep with MS conventions? if you are porting individual methods you need
>>> to match the surrounding code?
>>> Also, if you are porting an entire file, should the Microsoft copyright
>>> header be retained?
>>> I'm sure there are other things, so there probably needs to be a section
>>> on the site to cover the rules around porting from the reference source.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mono-devel-list