[Mono-dev] SetThreadPriority patch for mono-3.2.8

[Rafael Teixeira]

PRs are like branches, you can keep changing/adding things until it is
merged or dropped.

:)

On Fri Nov 07 2014 at 07:11:03 Bent Bisballe Nyeng <deva at aasimon.org> wrote:

> I'll look into the issues you describe. Should I have the PR reopened
> once I get it done or should I open up a new one?
>
> Kind regards
> Bent Bisballe Nyeng
>
> On 11/06/14 17:35, Rodrigo Kumpera wrote:
> > PR 1391 cannot be accepted for multiple reasons:
> >
> > -The commit message is empty and has no licensing;
> > -It changes MonoInternalThread layout for no good reason, the introduced
> > field is not used anywhere;
> > -It's adding code to the io-layer for which we don't want to continue to
> > expand;
> >
> > How to do it in way that's mergeable?
> >
> > Add a pair of functions to utils/mono-threads.h that get/set the
> priority.
> > Implement that functions on all backends or add stubs when appropriate.
> > Use this new API from metadata/threads.h to implement the managed
> > functionality;
> > Use C89.
> > License the code under the MIT license.
> >
> > --
> > Rodrigo
> >
> >
> >
> >
> >
> > On Thu, Nov 6, 2014 at 9:16 AM, Bent Bisballe Nyeng <deva at aasimon.org
> > <mailto:deva at aasimon.org>> wrote:
> >
> >     I have made pull request now:
> >     https://github.com/mono/mono/__pull/1391
> >     <https://github.com/mono/mono/pull/1391>
> >
> >     I have updated the patch to work with HEAD and tested it. Everything
> >     seems to work as expected.
> >
> >     I'm a bit new to the whole github concept, so forgive me if I have
> >     not done everything by the book ;-)
> >
> >     Kind regards
> >     Bent Bisballe Nyeng
> >
> >     On 11/06/14 12:37, Alexander Köplinger wrote:
> >
> >         There is a PR that also claims to implement SetThreadPriority
> >         (https://github.com/mono/mono/__pull/1272
> >         <https://github.com/mono/mono/pull/1272>), but it has many other
> >         unrelated changes, so not in a state to be merged.
> >           From a quick look, your patch seems to be much more focused
> >         and thus
> >         more likely to get merged. Can you open a pull request on GitHub?
> >
> >         -- Alex
> >
> >
> >           > Date: Thu, 6 Nov 2014 09:12:02 +0100
> >           > From: deva at aasimon.org <mailto:deva at aasimon.org>
> >           > To: mono-devel-list at lists.ximian.__com
> >         <mailto:mono-devel-list at lists.ximian.com>
> >           > Subject: [Mono-dev] SetThreadPriority patch for mono-3.2.8
> >           >
> >           > Hi mono devs
> >           >
> >           > I created a patch for SetThreadPriority support in
> >         mono-3.2.8 and would
> >           > very much like som feedback on it.
> >           > It can be found here:
> >           > https://gist.github.com/__aasimon/c8ae6fc3cf5d9b82b6ca
> >         <https://gist.github.com/aasimon/c8ae6fc3cf5d9b82b6ca>
> >           > Comments are welcome both here on the list as well as on the
> >         actual gist
> >           > paste.
> >           >
> >           > Kind regards
> >           > Bent Bisballe Nyeng
> >           > _________________________________________________
> >           > Mono-devel-list mailing list
> >           > Mono-devel-list at lists.ximian.__com
> >         <mailto:Mono-devel-list at lists.ximian.com>
> >           > http://lists.ximian.com/__mailman/listinfo/mono-devel-__list
> >         <http://lists.ximian.com/mailman/listinfo/mono-devel-list>
> >
> >
> >     _________________________________________________
> >     Mono-devel-list mailing list
> >     Mono-devel-list at lists.ximian.__com
> >     <mailto:Mono-devel-list at lists.ximian.com>
> >     http://lists.ximian.com/__mailman/listinfo/mono-devel-__list
> >     <http://lists.ximian.com/mailman/listinfo/mono-devel-list>
> >
> >
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141107/f2fab0b3/attachment.html>