[Mono-dev] SetThreadPriority patch for mono-3.2.8
Bent Bisballe Nyeng
deva at aasimon.org
Thu Nov 6 14:38:35 UTC 2014
I have added both test code and results as a comment to the pull request.
Bent Bisballe Nyeng
On 11/06/14 15:22, Andres G. Aragoneses wrote:
> Hey Bisballe,
> Thanks for putting your work as a pull request!
> It would be nice if you could include in it some unit tests that
> demonstrate that the feature is working correctly (this will probably
> also make the PR more likely to be reviewed/merged soon). You can find
> an example of such tests here:
> On 06/11/14 15:16, Bent Bisballe Nyeng wrote:
>> I have made pull request now: https://github.com/mono/mono/pull/1391
>> I have updated the patch to work with HEAD and tested it. Everything
>> seems to work as expected.
>> I'm a bit new to the whole github concept, so forgive me if I have not
>> done everything by the book ;-)
>> Kind regards
>> Bent Bisballe Nyeng
>> On 11/06/14 12:37, Alexander Köplinger wrote:
>>> There is a PR that also claims to implement SetThreadPriority
>>> (https://github.com/mono/mono/pull/1272), but it has many other
>>> unrelated changes, so not in a state to be merged.
>>> From a quick look, your patch seems to be much more focused and thus
>>> more likely to get merged. Can you open a pull request on GitHub?
>>> -- Alex
>>> > Date: Thu, 6 Nov 2014 09:12:02 +0100
>>> > From: deva at aasimon.org
>>> > To: mono-devel-list at lists.ximian.com
>>> > Subject: [Mono-dev] SetThreadPriority patch for mono-3.2.8
>>> > Hi mono devs
>>> > I created a patch for SetThreadPriority support in mono-3.2.8 and
>>> > very much like som feedback on it.
>>> > It can be found here:
>>> > https://gist.github.com/aasimon/c8ae6fc3cf5d9b82b6ca
>>> > Comments are welcome both here on the list as well as on the actual
>>> > paste.
>>> > Kind regards
>>> > Bent Bisballe Nyeng
>>> > _______________________________________________
>>> > Mono-devel-list mailing list
>>> > Mono-devel-list at lists.ximian.com
>>> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
More information about the Mono-devel-list