[Mono-dev] Proposed changes to mono/mcs/class/corlib/Mono/DataConverter.cs

[Michael McGlothlin]

How would I access your new version (In a different branch or such?)? How long until the changes will filter through to the NuGet package!

Thanks,
Sent from my iPad

> On Dec 9, 2014, at 8:25 AM, Miguel de Icaza <miguel at xamarin.com> wrote:
> 
> Hey,
> 
> I have a variation of this patch now.   I need to rebuild my Mono before i can commit it.
> 
> It will use a conditional compiler directive to use this other system
> 
>> On Mon, Dec 8, 2014 at 11:53 PM, Stephen Shaw <sshaw at decriptor.com> wrote:
>> I can't comment on the code changes themselves, but it would be helpful to fork mono on github and then create a Pull Request (PR) with your changes.
>> 
>> Cheers,
>> Stephen
>> 
>>> On Mon, Dec 8, 2014 at 8:54 PM, Michael McGlothlin <mike.mcglothlin at gmail.com> wrote:
>>> Couldn't figure out how to get Xamarin Studio to create an actual patch file after trying, and failing, to push a change with git. It appears this is the correct place to post this?
>>> 
>>> I usually put most of my code in PCL and then call it from platform specific code so I'm trying to make DataConverter happy as PCL.
>>> 
>>> To make DataConverter compile as PCL I had to change Encoding.UTF7 to Encoding.GetEncoding ( "utf-7" ) and the numeric calls to 12000 and 12001 on GetEncoding() to the string-based "utf-32" and "uff-32BE". These three changes had to be made twice as there are two variants using this same code. I also changed ArrayList to List<object> to make PCL happy.
>>> 
>>> 
>>> 
>>> 				case '7':
>>> 					e = Encoding.GetEncoding ("utf-7");
>>> 					n = 1;
>>> 					break;
>>> 				case '3':
>>> 					e = Encoding.GetEncoding ("utf-32");
>>> 					n = 4;
>>> 					break;
>>> 				case '4':
>>> 					e = Encoding.GetEncoding ("utf-32BE");
>>> 					n = 4;
>>> 					break;
>>> 
>>> 
>>> 
>>> 		static public IList Unpack (string description, byte[] buffer, int startIndex)
>>> 		{
>>> 			DataConverter conv = CopyConv;
>>> 			var result = new List<object> ();
>>> 			int idx = startIndex;
>>> 			bool align = false;
>>> 			int repeat = 0, n;
>>> 
>>> 
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>> 
>> 
>> 
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141217/447ae978/attachment.html>