[Mono-dev] OracleClient.Oci and GC

[Neale Ferguson]

Yeah, it is a sealed class which is why I didn't do protected virtual, so I'm wondering to what your initial remark referred: "Idiomatic IDisposable implementation is slightly different from what you have." 

On Aug 26, 2014, at 1:09 AM, Jonathan Pryor <jonpryor at vt.edu> wrote:

> On Aug 25, 2014, at 2:05 PM, Neale Ferguson <NealeFerguson at verizon.net> wrote:
>> Do you mean mine not having protected virtual? 
> 
> Dispose(bool) doesn't need to be `protected virtual` unless you plan on supporting inheritance.
> 
> Rephrased: if your type is sealed, it doesn't need to be `protected virtual`. If your type *isn't* sealed, your type probably should provide a `protected virtual void Dispose(bool disposing)`.
> 
> - Jon
>