[Mono-dev] Submitting patch?

[Rob Wilkens]

Someone replied to the commit/push/pull-request: (paraphrasing from 
memory): "Looks good to me.  Thanks"  --  I don't know whether or not 
that person is a TDS Driver Maintainer or not, though.  That was sganesh 
who apparently also is known as Nagappan if i typed that right.

I was thinking of building a test after geting the below message, 
looking at http://www.mono-project.com/Test_Suite .. And it says to run 
existing tests, go into class library directory (i.e. 
mcs/class/Mono.Data.Tds or 
mcs/class/Mono.Data.Tds/Mono.Data.Tds.Protocol and run 'make run-test' 
and i did and there were no existing tests in there to base a test on.  
It would be easier if i had some sample test to build on because i've 
never written a unit test before.


On 05/02/2012 07:28 AM, Rodrigo Kumpera wrote:
> Patches are much more likely to be accepted if they include tests. 
> It's up to the TDS driver maintainers.
>
> On Wed, May 2, 2012 at 8:26 AM, Rob Wilkens <robwilkens at gmail.com 
> <mailto:robwilkens at gmail.com>> wrote:
>
>     [resending reply via reply to list only, left off list in previous
>     reply]
>
>
>     I already did the pull request on github -- and i'm not sure how
>     to include the tests (I only commented that i ran the tests on
>     github in the pull comments).  Or do you mean i have to somehow
>     generate my own tests, which would be difficult because this
>     requires, i think, a functional microsoft sql server for it to
>     have access to to reproduce the error.
>
>     -Rob
>
>     On 05/02/2012 07:21 AM, Rodrigo Kumpera wrote:
>>     Please make it a pull request on github with tests included.
>>
>>
>>
>>     On Tue, May 1, 2012 at 12:55 PM, Rob Wilkens
>>     <robwilkens at gmail.com <mailto:robwilkens at gmail.com>> wrote:
>>
>>
>>         Ok, I looked up the 'selfish' way to submit a patch from the
>>         contributing section, and i think the below suffices as a
>>         patch, does anyone disagree?
>>
>>         I am referring to : http://www.mono-project.com/Contributing
>>         towards the bottom of the page where it simply says to submit
>>         the patch to the mailing list.
>>
>>         Does the below suffice as a "patch" or should i figure out
>>         the 'github' way which i thought i saw elsewhere.
>>
>>         -Rob
>>
>>         On 05/01/2012 11:49 AM, Rob Wilkens wrote:
>>>         I found out the fix for the error i reported with multiple invalid
>>>         login attempts...  It's very simple...
>>>
>>>         Mono.Data.TdsClient.TdsConnectionPool.cs
>>>
>>>         In the above file, in GetConnection(), either before:
>>>
>>>         goto retry
>>>
>>>         or after the initial
>>>
>>>         retry:
>>>
>>>         (either place should be fine)
>>>
>>>         result needs to be set to null -- that is:
>>>
>>>         result=null;
>>>
>>>         (in my testing, i put it before goto retry)
>>>
>>>         Otherwise, it keeps retrying because result has never been reset
>>>         before the while loop you are trying to enter.
>>>
>>>         I guess my next step is figuring out how to navigate github so i can submit it.
>>>
>>>         Sorry for being so public and crowding the mailing list with this.  If
>>>         someone else wants to volunteer to submit the patch for me, please
>>>         speak up.  I'll otherwise figure it out.
>>>
>>>         -Rob
>>
>>
>>         _______________________________________________
>>         Mono-devel-list mailing list
>>         Mono-devel-list at lists.ximian.com
>>         <mailto:Mono-devel-list at lists.ximian.com>
>>         http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>
>
>
>     _______________________________________________
>     Mono-devel-list mailing list
>     Mono-devel-list at lists.ximian.com
>     <mailto:Mono-devel-list at lists.ximian.com>
>     http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20120502/2460a49f/attachment.html>