[Mono-dev] Submitting patch?
robwilkens at gmail.com
Wed May 2 11:26:38 UTC 2012
[resending reply via reply to list only, left off list in previous reply]
I already did the pull request on github -- and i'm not sure how to
include the tests (I only commented that i ran the tests on github in
the pull comments). Or do you mean i have to somehow generate my own
tests, which would be difficult because this requires, i think, a
functional microsoft sql server for it to have access to to reproduce
On 05/02/2012 07:21 AM, Rodrigo Kumpera wrote:
> Please make it a pull request on github with tests included.
> On Tue, May 1, 2012 at 12:55 PM, Rob Wilkens <robwilkens at gmail.com
> <mailto:robwilkens at gmail.com>> wrote:
> Ok, I looked up the 'selfish' way to submit a patch from the
> contributing section, and i think the below suffices as a patch,
> does anyone disagree?
> I am referring to : http://www.mono-project.com/Contributing
> towards the bottom of the page where it simply says to submit the
> patch to the mailing list.
> Does the below suffice as a "patch" or should i figure out the
> 'github' way which i thought i saw elsewhere.
> On 05/01/2012 11:49 AM, Rob Wilkens wrote:
>> I found out the fix for the error i reported with multiple invalid
>> login attempts... It's very simple...
>> In the above file, in GetConnection(), either before:
>> goto retry
>> or after the initial
>> (either place should be fine)
>> result needs to be set to null -- that is:
>> (in my testing, i put it before goto retry)
>> Otherwise, it keeps retrying because result has never been reset
>> before the while loop you are trying to enter.
>> I guess my next step is figuring out how to navigate github so i can submit it.
>> Sorry for being so public and crowding the mailing list with this. If
>> someone else wants to volunteer to submit the patch for me, please
>> speak up. I'll otherwise figure it out.
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> <mailto:Mono-devel-list at lists.ximian.com>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mono-devel-list