[Mono-dev] Patches for mono-winforms

[Stifu]

Sorry, I was wrong: bug 5834 *is* caused by patch 6, too. (I messed up my
tests as I'm juggling between .NET 2.0 or 4.0 depending on the application
I'm testing, which have separate WinForms DLLs.)

I'll go ahead and commit my fix, then.


Stifu wrote
> 
> The thought crossed my mind, but I'm not sure about that. Because with
> VisualStyles enabled, ToolStrips do not have a solid background color, but
> a gradient, that's why I thought we should only paint the background if
> there is a non-default one specified. I've seen other such cases like that
> in .NET, with other controls.
> 
> By the way, my proposed patch had a little problem:
> 
> "if (e.Item.Parent.BackColor != Control.DefaultBackColor) {"
> 
> The ".Parent" part should be removed.
> 
> 
> Steven Boswell II wrote
>> 
>> It seems to me that patch 6 revealed another bug, it didn't cause one.
>>  The problem seems to be that the default background color of
>> tool-strip-items is set wrong, i.e. bug 5834 describes the general
>> problem.  Your proposed patch seems, to me, to be too specific to the
>> example.
>> 
>> I would start by checking the default background colors in .NET and
>> making sure Mono is using the same colors.
>> 
>> 
>> ________________________________
>>  From: Stifu <stifu@>
>> To: mono-devel-list at .ximian 
>> Sent: Saturday, June 23, 2012 4:19 PM
>> Subject: Re: [Mono-dev] Patches for mono-winforms
>>  
>> I just noticed patch 6
>> (https://github.com/mono/mono/commit/3d04a14a278d6160e33c16b52b86d68fe45d80b1)
>> caused a regression.
>> 
>> See the attached screenshot (top: before patch, bottom: after patch).
>> http://mono.1490590.n4.nabble.com/file/n4650149/toolstripitems.png
>> toolstripitems.png 
>> 
>> The application this screenshot is from:
>> http://epicedit.stifu.fr/download/EpicEdit_2.5.zip
>> 
>> By the way, I just reported bug 5834
>> (https://bugzilla.xamarin.com/show_bug.cgi?id=5834), which may be
>> related,
>> except that one isn't a regression. Maybe we can kill two birds with one
>> stone.
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 

--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4650153.html
Sent from the Mono - Dev mailing list archive at Nabble.com.