[Mono-dev] Restart my fork?

Stifu stifu at free.fr
Sun Jun 17 13:26:35 UTC 2012


Please separate each patch, so I can review them one by one. This is just too
big to review, and I don't know even know what it's trying to fix.
Also, please give me the concerned bug reports, if any.


Robert Wilkens wrote
> 
> Ok, if you are willing to look at it, i've attached it if i did it
> right...
> 
> I did a git diff <commit just before first commit> <last commit> 
> 
> That should have the whole range of changes of all the commits,
> hopefully i've attached the right file too.
> 
> This should align with the following pull request on github.com:
> https://github.com/mono/mono/pull/322
> Which originally was a closed pull request which i cancelled when i
> needed to make additional changes:
> https://github.com/mono/mono/pull/312
> 
> I'm probably not going to be home all day today, so if you have
> questions, i am willing to answer them but i may be delayed.  I'll try
> to bring my laptop if i do go out.
> 
> -Rob
> 
> On 06/17/2012 08:21 AM, Stifu wrote:
>> Can't really give Git-related advices, I suck at it, but I can easily
>> review
>> WinForms patches if you simply attach them to your messages the
>> old-school
>> way.
>>
>>
>> Robert Wilkens wrote
>>> My master branch contains two unrelated winforms changes (one change for
>>> idle, one change for DataGrid - not DataGridView don't worry i'm not
>>> duplicating work), it's becoming clear that they are not going to
>>> receive priority and i have no problem with that.
>>>
>>> But i do have at least one non-winforms fix which i'd like to at least
>>> get reviewed.  That's not going to happen since the winforms changes
>>> have to go thru first.
>>>
>>> Is it considered a safe thing to:
>>> 1) Backup the files that i changed for each fix
>>> 2) Delete my fork
>>> 3) Create a new fork
>>> 4) Create branches for each change and submit them separately
>>>
>>> I think this would help me get past my current state of 'i can't really
>>> do anything until my master branch is approved or rejected'...
>>>
>>> I probably won't do this today, but if I don't hear back i might do that
>>> sometime this week.
>>>
>>> -Rob
>>>
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at .ximian
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>
>>
>> --
>> View this message in context:
>> http://mono.1490590.n4.nabble.com/Restart-my-fork-tp4650004p4650006.html
>> Sent from the Mono - Dev mailing list archive at Nabble.com.
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 


--
View this message in context: http://mono.1490590.n4.nabble.com/Restart-my-fork-tp4650004p4650009.html
Sent from the Mono - Dev mailing list archive at Nabble.com.


More information about the Mono-devel-list mailing list