[Mono-dev] Patches for mono-winforms

Sun Jun 17 10:20:08 UTC 2012

Do you want me to try this?  Does it make a difference what platform i try this on?  Is the one patch the only patch that is required for this?  Does it matter whether i tested with my older robwilkens/mono tree or do i need to test with the latest and greatest (and not building,, though i've got a tree half-built that fixes that) version of mono.

-rob

On Jun 17, 2012, at 4:21 AM, Stifu wrote:

> To clear things up, when running with .NET, I do *not* get the error. I was
> just making it clear that whether I *build* the application with .NET or
> Mono doesn't make a difference. So what Rob sees matches what I see.
> 
> Running with .NET: works
> Running with Mono: error
> 
> Except Rob didn't check this last one:
> 
> Running with patched Mono: error
> 
> 
> Steven Boswell II wrote
>> 
>> Thanks, Rob.  That's exactly what I expect would happen.  Only by building
>> latest Mono, with the patch, will the project's test succeed with Mono.
>> 
>> Don't worry about stretching your patience -- the fact that you got it to
>> succeed in .NET was plenty helpful.
>> 
>> Stifu..."whether I build it with .NET or Mono, I get the error I
>> mentioned, running the application with Mono on Windows"...if you ran it
>> with unpatched Mono, that's what I expect to happen.  If you ran it with
>> patched Mono or with .NET, I wouldn't.  What exactly did you do?
>> 
>> Steven Boswell
>> 
>> 
>> ________________________________
>> From: Rob Wilkens <robwilkens@>
>> To: mono-devel-list at .ximian 
>> Sent: Saturday, June 16, 2012 5:41 PM
>> Subject: Re: [Mono-dev] Patches for mono-winforms
>> 
>> As per the test project mentioned, I just tested with Microsoft Visual
>> Studio 2010 professional, on Windows 7, with Microsoft .NET (By clicking
>> Debug->Start Debugging to run it), this does not raise any exceptions
>> (no message box), it leaves me with an open window.  I also tested on
>> Mono on Windows (version 2.10.8) and the test fails in mono, seemingly
>> before a window is displayed on the screen.
>> 
>> Again, i know my opinion is of mixed value.
>> 
>> BTW - I did not try applying the patch in mono, i don't have the
>> patience right now (unless you want me to) to build mono in windows.
>> 
>> -Rob
>> 
>> 
>> 
>> On 06/16/2012 06:39 PM, Stifu wrote:
>>> I wasn't talking about the mailing list in particular, but any media
>>> (bugzilla, Git...). My point was that getting that many patches pushed
>>> within such a short time, for a part that is no longer maintained by the
>>> Mono team, is pretty good. I'd have been pretty happy if my patches
>>> received
>>> that much attention a few years ago.
>>> 
>>> Anyway, about patch 2, whether I build it with .NET or Mono, I get the
>>> error
>>> I mentioned, running the application with Mono on Windows. So unless this
>>> is
>>> an OS-specific issue, I don't know what's the problem. I'll try to check
>>> it
>>> out on Linux, whenever I can find some time. Meanwhile, if anyone wants
>>> to
>>> review the patch, feel free.
>>> 
>>> 
>>> Steven Boswell II wrote
>>>> Are you saying that there have been bug fixes submitted to this mailing
>>>> list, that have sat around for YEARS without being acted upon by those
>>>> with version-control-commit authority...?
>>>> 
>>>> I installed latest mono to /usr/local, compiled my test with "gmcs
>>>> -out:DgvTest.exe Program.cs -r:System -r:System.Windows.Forms -r
>>>> System.Drawing", and ran it with "mono DgvTest.exe", and it runs fine
>>>> for
>>>> me.  So I guess we're back to having an impasse.  Sigh.
>>>> 
>>>> Steven Boswell
>>>> 
>>>> 
>>>> ________________________________
>>>>   From: Stifu <stifu@>
>>>> To: mono-devel-list at .ximian 
>>>> Sent: Saturday, June 16, 2012 1:09 AM
>>>> Subject: Re: [Mono-dev] Patches for mono-winforms
>>>>   
>>>> Honestly, you've had it much better than the vast majority. :)
>>>> Some others have been waiting for years. Also, now you can add NUnit to
>>>> your
>>>> resume. :p
>>>> 
>>>> Anyway, I get a "1-1: expected not null, found null" message box in
>>>> DgvTest4
>>>> with Mono, even after applying your patch.
>>>> 
>>>> 
>>>> Steven Boswell II wrote
>>>>> I agree, but we both know how much toil it takes to get our bug fixes
>>>>> accepted and applied to the git repository on this mailing list... ;-)
>>>>> 
>>>>> 
>>>>> ________________________________
>>>>>    From: Rob Wilkens <robwilkens@>
>>>>> To: mono-devel-list at .ximian 
>>>>> Sent: Friday, June 15, 2012 5:42 PM
>>>>> Subject: Re: [Mono-dev] Patches for mono-winforms
>>>>>   
>>>>> 
>>>>> I know my opinion is of mixed value, but it looks to make sense to me.. 
>>>>> If the toolstripitem is being changed so it no longer has an owner,
>>>>> calculating a size might not make sense....
>>>>> 
>>>>> -Rob
>>>>> 
>>>>> On 06/15/2012 08:34 PM, Steven Boswell II wrote: 
>>>>> [... Digging through the stack trace, I arrived at
>>>>> System.Windows.Forms.ToolStripItem.set_InternalOwner, where the owner
>>>>> was
>>>>> being set to null, and right afterwards, CalculateAutoSize() was being
>>>>> called.  Why would anyone need to calculate the size of a menu-item
>>>>> that
>>>>> isn't even connected to a menu any more?  So, for me, the bug fix was
>>>>> obvious: check if the owner isn't null before
>>>>> calling CalculateAutoSize().
>>>>>   That's what the enclosed patch does. ...]
>>>>> _______________________________________________
>>>>> Mono-devel-list mailing list
>>>>> Mono-devel-list at .ximian
>>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>>> 
>>>> 
>>>> --
>>>> View this message in context:
>>>> http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649980.html
>>>> Sent from the Mono - Dev mailing list archive at Nabble.com.
>>>> _______________________________________________
>>>> Mono-devel-list mailing list
>>>> Mono-devel-list at .ximian
>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>> _______________________________________________
>>>> Mono-devel-list mailing list
>>>> Mono-devel-list at .ximian
>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>> 
>>> 
>>> --
>>> View this message in context:
>>> http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649989.html
>>> Sent from the Mono - Dev mailing list archive at Nabble.com.
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at .ximian
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 
> 
> --
> View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649995.html
> Sent from the Mono - Dev mailing list archive at Nabble.com.
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list