[Mono-dev] Patches for mono-winforms

[Stifu]

Patch 7 has been pushed
(https://github.com/mono/mono/commit/1743a005ccdc0d8c93795e236d2a5a32043b722c).
Only one left.


Stifu wrote
> 
> I'll take care of this soon.
> 
> For the record, I'll go ahead and change the visibility of all new test
> classes and struct to private. I don't think they need to be public. If
> they actually do (to reuse them in other test classes later), then they
> should probably be moved to a helper class.
> 
> 
> Steven Boswell II wrote
>> 
>> Argh...I missed the all-important "dgv.Parent = form;" line.
>> Try this one.
>> 
>> 
>> ________________________________
>>  From: Stifu <stifu@>
>> To: mono-devel-list at .ximian 
>> Sent: Sunday, June 10, 2012 2:47 PM
>> Subject: Re: [Mono-dev] Patches for mono-winforms
>>  
>> Test fails with .NET.
>> 
>> 1-1
>>   Expected: not null
>>   But was:  null
>> 
>> 
>> Steven Boswell II wrote
>>> 
>>> Then here's the (hopefully) final version of patch #7.
>>> 
>>> Next will be a version of patch #2 with a unit test, and then...I'll
>>> have
>>> to work on the other bugs in my list. :-)
>>> 
>>> Steven Boswell
>>> 
>>> 
>>> ________________________________
>>>  From: Stifu <stifu@>
>>> To: mono-devel-list at .ximian 
>>> Sent: Sunday, June 10, 2012 1:45 PM
>>> Subject: Re: [Mono-dev] Patches for mono-winforms
>>>  
>>> I don't know for sure, but if there seems to be no nicer way, let's go
>>> for
>>> that. It can still be changed later anyway. Other unit tests are
>>> certainly
>>> not perfect anyway, there are a couple that fail with .NET.
>>> 
>>> 
>>> Steven Boswell II wrote
>>>> I figured out why my unit-test project for patch #7 wasn't working in
>>>> MS
>>>> Windows.  Enclosed is a version of the project that works both under
>>>> Linux
>>>> and MS Windows.
>>>> 
>>>> My main question is, should I include all that MS-Windows-specific code
>>>> in
>>>> the actual unit test?  I found one other unit test
>>>> under Test/System.Windows.Forms that uses DllImport --
>>>> DateTimePickerTest.cs .  So there seems to be some precedent.
>>>> 
>>>> Let me know what the right thing to do is, and I'll submit a final
>>>> version
>>>> of patch #7.
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at .ximian
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>> 
>> 
>> --
>> View this message in context:
>> http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649857.html
>> Sent from the Mono - Dev mailing list archive at Nabble.com.
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 


--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649879.html
Sent from the Mono - Dev mailing list archive at Nabble.com.