[Mono-dev] I think i've fixed the whitespace

[Robert Wilkens]

I started building all of mono on cygwin, should i expect problems?

I'm working on my mac at the moment, autogen complained that it needed get text so i downloaded and am installing/building-from-scratch that now.

Thanks
Rob

On Jun 10, 2012, at 8:34 AM, Stifu wrote:

> Yes, if you change the driver parts, you should test on the concerned OS.
> 
> With cygwin, are you building all of Mono, or just the assembly you need?
> 
> 
> Rob Wilkens wrote
>> 
>> Thanks - if you get the time, great, if not, it's ok.
>> 
>> In my original commit, I made changes to:
>> XplatUICarbon.cs - so I probably should test on my mac
>> and
>> XplatUIWin32.cs - and i probably should test on windows 7
>> 
>> While i didn't change interfacing with the display managers, only calls to
>> the idle event handler, I think that it would be wise to test.
>> 
>> I've already got the cygwin thing building, buggy or not, so i'm hoping
>> just to let that go.  That's running in a virtual machine in Linux
>> (Windows 7 in VirtualBox).  On My Mac upstairs now (not a laptop) I'm
>> downloading from github (just sent my ssh key over so i could).  I will
>> try to start a build on the mac today too.  No promises on whether either
>> of these finish in reasonable time because both systems go to 'sleep'
>> often (the mac automatically, and the laptop, when i close the lid).  The
>> cygwin build seems slow, not sure what to expect from the mac.
>> 
>> -Rob
>> 
>> 
>> On Jun 10, 2012, at 8:10 AM, Stifu wrote:
>> 
>>> I might be able to look at your fixes at some point, but no promises.
>>> 
>>> Testing only on X11 isn't an issue for most changes.
>>> 
>>> By the way, I'm a Windows user but don't bother with cygwin anymore. I
>>> just
>>> can't stand that thing. I just grab the sources from Git and build them
>>> with
>>> my IDE (that requires fixing some references first, for WinForms).
>>> 
>>> Carbon is what's used by the Mac WinForms driver. For the record, the
>>> Carbon
>>> driver is full of bugs that aren't there on Windows or Linux.
>>> 
>>> 
>>> Rob Wilkens wrote
>>>> 
>>>> Ok, I've corrected the Whitespace issues...  You will only see the 
>>>> changes in pull request one of two because pull request 2 is on a 
>>>> different branch even though it contains some of the same commits.
>>>> 
>>>> I've also now labelled my pull requests in the sequence they are 
>>>> intended to come in..
>>>> 
>>>> I know my first three pull requests were pulled in by the infamous 
>>>> Miguel Di Icaza, whom i heard of years ago before i was even a mono 
>>>> user.  Not sure if i  need to wait for him to have free time to review 
>>>> these changes, and i understand he's busy so i'm not rushing anything.
>>>> 
>>>> My code was only tested on X11, is that an issue?  If so, i started a 
>>>> build on Win32 (With CygWin) and may be able to test on my Mac 
>>>> afterwards too.  I'm not sure about other platforms (what's a 'carbon').
>>>> 
>>>> -Rob
>>>> _______________________________________________
>>>> Mono-devel-list mailing list
>>>> Mono-devel-list at .ximian
>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>> 
>>> 
>>> 
>>> --
>>> View this message in context:
>>> http://mono.1490590.n4.nabble.com/I-think-i-ve-fixed-the-whitespace-tp4649843p4649844.html
>>> Sent from the Mono - Dev mailing list archive at Nabble.com.
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at .ximian
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 
> 
> --
> View this message in context: http://mono.1490590.n4.nabble.com/I-think-i-ve-fixed-the-whitespace-tp4649843p4649846.html
> Sent from the Mono - Dev mailing list archive at Nabble.com.
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list