[Mono-dev] Patches for mono-winforms

[Stifu]

"Um...you're not supposed to get the "Event handler!" message-box with an
unpatched Mono.  The patch's main purpose is to make sure that event handler
gets called.  Or do I misunderstand what you're saying?"

Then isn't the test wrong? If the event handler doesn't get executed, then
the unit test still passes. I just tried commenting the event handler and
run the test with .NET, and it passes.

By the way, I think there may have been issues with patch 3... Now the
concerned 2 tests (SelectedColumnsTest and SelectedRowsTest) don't pass
anymore with .NET, it seems.

I get: 1-14
  Expected: 0
  But was:  2

Can you confirm? I did stumble across this error while reviewing your patch,
but then I thought it ended up passing. I must have made a mistake
somewhere.

I didn't actually find your GitHub account, just referenced your e-mail
address and that's it. :p
C# Qt bindings is a cool project. I was gonna mention CXXI, but you already
know about it.


Steven Boswell II wrote
> 
> Um...you're not supposed to get the "Event handler!" message-box with an
> unpatched Mono.  The patch's main purpose is to make sure that event
> handler gets called.  Or do I misunderstand what you're saying?
> 
> Thanks for committing my other patch.  I had totally forgotten about my
> account on GitHub.  Kudos for finding it. :-)
> 
> Steven Boswell
> 
> 
> ________________________________
>  From: Stifu <stifu@>
> To: mono-devel-list at .ximian 
> Sent: Saturday, June 9, 2012 12:03 AM
> Subject: Re: [Mono-dev] Patches for mono-winforms
>  
> By "ran fine", do you mean you do get the "Event handler!" message box?
> Because I don't, with Mono (unpatched).
> 
> Patch 8 pushed, slightly reformatted
> (https://github.com/mono/mono/commit/641ae7303320c2bad8ff83f9b5f9fc0d285b6b0e).
> Thanks.
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 

--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649820.html
Sent from the Mono - Dev mailing list archive at Nabble.com.