[Mono-dev] Patches for mono-winforms

[Stifu]

By "ran fine", do you mean you do get the "Event handler!" message box?
Because I don't, with Mono (unpatched).

Patch 8 pushed, slightly reformatted
(https://github.com/mono/mono/commit/641ae7303320c2bad8ff83f9b5f9fc0d285b6b0e).
Thanks.

Rob: WPF is no more open than WinForms, and both start with "Windows"
anyway.
By the way, as far as I'm concerned, WPF is pretty much dead (possibly
more-so than WinForms). At first, the Mono team didn't want to implement it
because it was too big, too complex, and they just didn't have enough
resources to do it. At this point, I think it's no longer worth
reimplementing even if they had the resources for it.


Steven Boswell II wrote
> 
> Well, that sample ran fine on my side, so I guess we have a problem.  Any
> idea how to resolve this issue?
> 
> Re: using themes...sure, that's a long-term solution, but since
> mono-winforms is no longer officially supported, and Microsoft has moved
> on to WPF, I'd say the chances of this happening are between slim and
> none.  Still...enclosed is a newer version of the same patch, one that
> uses ThemeEngine.Current.ColorGrayText instead.
> 
> Please let me know if there's anything else I need to do on this bug,
> especially since it's a visual change & so it's pretty much impossible to
> make a unit test for it.
> 
> BTW, I couldn't find any bug reports for this issue.
> 
> Steven Boswell
> 
> 
> ________________________________
>  From: Stifu <stifu@>
> To: mono-devel-list at .ximian 
> Sent: Thursday, June 7, 2012 11:13 PM
> Subject: Re: [Mono-dev] Patches for mono-winforms
>  
> The one solution I uploaded doesn't have the hang, but it has the
> never-called event handler.
> I haven't tried anything else since then.
> 
> I did notice issues with the disabled look of some controls, too (probably
> have some related bug reports still up on Novell bugzilla). I think this
> should all be handled within System.Windows.Forms.Theming, but it's not
> always the case with existing code. Ideally, we should gradually move
> theme-related code from System.Windows.Forms to
> System.Windows.Forms.Theming. Just saying that for the information, not
> saying we should do both fixing and moving things in the same patch.
> 
> 
> Steven Boswell II wrote
>> 
>> Stifu, did you have any better luck running your DgwTest, or my patch #1,
>> successfully?  I was never able to reproduce the hang you described.
>> 
>> I will hopefully have time and energy this weekend to write unit tests
>> for
>> more of the patches I sent earlier.
>> 
>> I want to fix the appearance of disabled ListBox controls -- currently,
>> they don't look any different than enabled ListBox controls.  Digging
>> around the other controls, it seems that most of them simply draw the
>> text
>> with the GrayText color, they don't do anything fancier than that to
>> implement the disabled look.  Enclosed is a patch that does that for
>> ListBox.  If you know of a better way to accomplish this effect, I'm all
>> ears.
>> 
>> Steven Boswell
>> 
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 
> --
> View this message in context:
> http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649781.html
> Sent from the Mono - Dev mailing list archive at Nabble.com.
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 

--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649809.html
Sent from the Mono - Dev mailing list archive at Nabble.com.