[Mono-dev] Patches for mono-winforms

[Steven Boswell II]

Well, that sample ran fine on my side, so I guess we have a problem.  Any idea how to resolve this issue?

Re: using themes...sure, that's a long-term solution, but since mono-winforms is no longer officially supported, and Microsoft has moved on to WPF, I'd say the chances of this happening are between slim and none.  Still...enclosed is a newer version of the same patch, one that uses ThemeEngine.Current.ColorGrayText instead.

Please let me know if there's anything else I need to do on this bug, especially since it's a visual change & so it's pretty much impossible to make a unit test for it.

BTW, I couldn't find any bug reports for this issue.

Steven Boswell


________________________________
 From: Stifu <stifu at free.fr>
To: mono-devel-list at lists.ximian.com 
Sent: Thursday, June 7, 2012 11:13 PM
Subject: Re: [Mono-dev] Patches for mono-winforms
 
The one solution I uploaded doesn't have the hang, but it has the
never-called event handler.
I haven't tried anything else since then.

I did notice issues with the disabled look of some controls, too (probably
have some related bug reports still up on Novell bugzilla). I think this
should all be handled within System.Windows.Forms.Theming, but it's not
always the case with existing code. Ideally, we should gradually move
theme-related code from System.Windows.Forms to
System.Windows.Forms.Theming. Just saying that for the information, not
saying we should do both fixing and moving things in the same patch.


Steven Boswell II wrote
> 
> Stifu, did you have any better luck running your DgwTest, or my patch #1,
> successfully?  I was never able to reproduce the hang you described.
> 
> I will hopefully have time and energy this weekend to write unit tests for
> more of the patches I sent earlier.
> 
> I want to fix the appearance of disabled ListBox controls -- currently,
> they don't look any different than enabled ListBox controls.  Digging
> around the other controls, it seems that most of them simply draw the text
> with the GrayText color, they don't do anything fancier than that to
> implement the disabled look.  Enclosed is a patch that does that for
> ListBox.  If you know of a better way to accomplish this effect, I'm all
> ears.
> 
> Steven Boswell
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 

--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649781.html
Sent from the Mono - Dev mailing list archive at Nabble.com.
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20120608/c76701da/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mwf-08-ListBox-draw-disabled.patch
Type: application/octet-stream
Size: 817 bytes
Desc: not available
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20120608/c76701da/attachment-0001.obj>