[Mono-dev] Patches for mono-winforms

[Steven Boswell II]

Yeah, I get target-fixation too sometimes. :-)

I only see three failing WinForms tests currently:

1) MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataMemberBeforeDataSource : System.ArgumentException : dataMember
at System.Windows.Forms.ListBindingHelper.GetList (System.Object dataSource, System.String dataMember) [0x00107] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ListBindingHelper.cs:81
at System.Windows.Forms.BindingSource.ResetList () [0x0000c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:140
at System.Windows.Forms.BindingSource.set_DataSource (System.Object value) [0x0003c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:353
at (wrapper remoting-invoke-with-check) System.Windows.Forms.BindingSource:set_DataSource (object)
at MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataMemberBeforeDataSource () [0x0002c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/Test/System.Windows.Forms/BindingSourceTest.cs:804
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x000d5] in /home/sboswell/Src/Mono/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:229

2) MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataSourceAssignToDefaultType : System.ArgumentException : dataMember
at System.Windows.Forms.ListBindingHelper.GetList (System.Object dataSource, System.String dataMember) [0x00107] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/ListBindingHelper.cs:81
at System.Windows.Forms.BindingSource.ResetList () [0x0000c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:140
at System.Windows.Forms.BindingSource.set_DataSource (System.Object value) [0x0003c] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/System.Windows.Forms/BindingSource.cs:353
at (wrapper remoting-invoke-with-check) System.Windows.Forms.BindingSource:set_DataSource (object)
at MonoTests.System.Windows.Forms.DataBinding.BindingSourceTest.DataSourceAssignToDefaultType () [0x0003e] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/Test/System.Windows.Forms/BindingSourceTest.cs:815
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x000d5] in /home/sboswell/Src/Mono/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:229

3) MonoTests.System.Windows.Forms.DataBinding.CurrencyManagerTest2.TestInsertRowAtCurrent :   2
  String lengths are both 112. Strings differ at index 91.
  Expected: "...ged (index = -1)\n3: PositionChanged (to 2)\n4: Binding.Format\n"
  But was:  "...ged (index = -1)\n3: PositionChanged (to 1)\n4: Binding.Format\n"
  -------------------------------------------------------^

at MonoTests.System.Windows.Forms.DataBinding.CurrencyManagerTest2.TestInsertRowAtCurrent () [0x00161] in /home/sboswell/Src/Mono/mono/mcs/class/Managed.Windows.Forms/Test/System.Windows.Forms/DataBindingTests.cs:552
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x000d5] in /home/sboswell/Src/Mono/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:229


________________________________
 From: Stifu <stifu at free.fr>
To: mono-devel-list at lists.ximian.com 
Sent: Sunday, July 29, 2012 11:04 AM
Subject: Re: [Mono-dev] Patches for mono-winforms
 
Ah, thanks for the fix. It's in. I overlooked these regressions as I was
solely focused on the new test.
Out of curiosity, do you also see 5 remaining failing WinForms tests?

Steven Boswell II wrote
> 
> The following patch fixes the two recently-broken WinForms unit tests.
> Stifu?  You checked in ermshiperete's change without running unit tests?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20120729/a81ae555/attachment.html>