[Mono-dev] Newly broken WinForms unit tests

[Stifu]

My mistake: MenuTest used to have an Assert.Throws, but it's been changed.
https://github.com/mono/mono/commit/b827712d7615bbbc919dc4e0f6ae0697279d6477

I'll do the same to DataGridViewTest.TestDispose(), then.


Steven Boswell II wrote
> 
> My copy of Mono only has NUnit 2.4, i.e. the mcs/nunit24 directory.
> My copy of mcs/nunit24/NUnitFramework/framework/Assert.cs does not have
> any Throws() methods.
> My copy of MenuTest doesn't call Throws().
> 
> "git pull" says "Already up-to-date."
> nunit.framework.dll seems to be installed on my machine via MonoDevelop.
> In the mono source directory, all I could find
> was external/cecil//Test/libs/nunit-2.5.10/nunit.framework.dll, and that
> doesn't appear to be built from source.
> 
> Am I in an evil parallel universe again? :-)
> 
> Steven Boswell
> 
> 
> ________________________________
>  From: Stifu <stifu@>
> To: mono-devel-list at .ximian 
> Sent: Saturday, July 28, 2012 3:10 PM
> Subject: Re: [Mono-dev] Newly broken WinForms unit tests
>  
> Hmm, Assert.Throws() has been introduced in NUnit 2.5. It's also used in
> MenuTest, by the way.
> Not sure what's wrong.
> 
> 
> Steven Boswell II wrote
>> 
>> Some time after 7pm MST last night, changes were checked in that broke
>> three WinForms unit tests.
>> 
>> 1) MonoTests.System.Windows.Forms.DataGridViewTestTestDispose() refers to
>> NUnit.Framework.Assert.Throws(), which used to be there, but doesn't seem
>> to be any more.  (I know that Assert.Throws() was in NUnit.Framework as
>> of
>> July 22, the last time I built an RPM package for latest Mono.)
>> 2) MonoTests.System.Windows.Forms.DataGridViewTest.SelectedColumnsTest
>> crashes in Dispose().
>> 3) MonoTests.System.Windows.Forms.DataGridViewClipboardTest.Test also
>> crashes in Dispose().
>> 
>> Could the responsible party please look into this?
>> 
>> Steven Boswell
>> 
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 
> 
> 
> --
> View this message in context:
> http://mono.1490590.n4.nabble.com/Newly-broken-WinForms-unit-tests-tp4650620p4650621.html
> Sent from the Mono - Dev mailing list archive at Nabble.com.
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at .ximian
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 



--
View this message in context: http://mono.1490590.n4.nabble.com/Newly-broken-WinForms-unit-tests-tp4650620p4650624.html
Sent from the Mono - Dev mailing list archive at Nabble.com.