[Mono-dev] Patches for mono-winforms

[Stifu]

By the way, Steven, you might want to check out this bug, as it's related to
some of your contributions:
https://bugzilla.novell.com/show_bug.cgi?id=683213

Before your patch(es), the DataGridView SelectionChanged event wasn't fired
with the test case attached to this report. Now, it seems it's fire twice
rather than once (despite the fact I said in the bug comments that the bug
seemed fixed). If you can't think of a way to fix this, it's alright. Just
thought I'd bring that up.


Stifu wrote
> 
> It's in
> (https://github.com/mono/mono/commit/75714e424afd2ee458e1288d756c914a4df2554f),
> thanks again.
> 
> 
> Steven Boswell II wrote
>> 
>> Enclosed is the third patch for TableLayoutPanel.  Our application has a
>> table-layout with column-spanning controls, and no control started in one
>> particular column.  Mono set that column width to zero; .NET didn't.
>> 
>> I solved it by generating row/column sizes in N passes, where N is the
>> largest row/column span of any control.  Each pass only increases the
>> width/height of the rightmost/bottommost column/row.
>> 
>> This gets Mono's behavior VERY close to .NET -- the unit test allows for
>> 3 pixels of difference.  I don't know what the source of that is, but
>> it's a heck of a lot better than what the previous code did.
>> 
>> I had to include the substance of patch #2 in this one, or else three
>> other existing unit-tests failed.  I guess my two bugs fixes couldn't be
>> separated after all :-)
>> 
>> As usual, apply the unit-test patch, watch it fail, apply the patch,
>> watch it succeed, and use the project to verify behavior under .NET and
>> MS Windows.
>> 
>> Steven Boswell
>> 
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 




--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4650606p4650614.html
Sent from the Mono - Dev mailing list archive at Nabble.com.