[Mono-dev] Patches for mono-winforms

[Stifu]

I had a look at the unit test for patch 20. The
EditingControlShowingTest_Unbound test method fails with .NET
(ArgumentOutOfRangeException). Something must be wrong with it.


Stifu wrote
> 
> Let's not take bad habits. :)
> Thanks for the test.
> 
> I did make the unit test for ermshiperete's patch, since he doesn't seem
> to be active anymore. It was that one with the Assert.Throws. :\ I just
> committed it separately, since the author was different.
> Anyway... I missed patch 19 somehow, but it doesn't come with a test
> either.
> 
> I saw patch 18a, but thought I'd leave it to the people who've been
> following / pushing Rob's patches. But if nobody's going to handle it,
> I'll do it. Eventually.
> 
> PS: patch 10 never got committed either, in case you overlooked that.
> 
> 
> Steven Boswell II wrote
>> 
>> So ermshiperete gets to check in changes with no unit tests that break
>> stuff, and I have to submit unit tests to prove I fixed those bugs?
>> 
>> I'm just jealous, is all ;-)
>> 
>> Enclosed is the desired unit test for patch #20.
>> 
>> Any thoughts on checking in patches #18a and #19?
>> 
>> Steven Boswell
>> 
>> 
>> ________________________________
>>  From: Steven Boswell II <ulatekh@>
>> To: "mono-devel-list at .ximian" <mono-devel-list at .ximian> 
>> Sent: Monday, August 6, 2012 6:32 PM
>> Subject: [Mono-dev] Patches for mono-winforms
>>  
>> 
>> https://github.com/mono/mono/commit/ecef298bcaf571a3d50e022318b20117f9d0388c
>> introduced another bug that I found today.  Enclosed is the fix.
>> 
>> 
>> [...]
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at .ximian
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> 
> 



--
View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4650777p4650891.html
Sent from the Mono - Dev mailing list archive at Nabble.com.