[Mono-dev] Mono and medium trust

[quandary]

I disagree on the small size.
My model names weren't that much larger, even though they had a path.
Even on a small name like "kernel32.dll" it will compare 4 letters 8
times before finding a match.
But i agree on not touching tested code ;)

However, filing this as a bug...
It honestly isn't one, and I wouldn't give it too much of a priority.

Better add a new cathegory, like "non-fatal nice-to-solve performance
issues".



On 09/03/2011 03:21 PM, Robert Jordan wrote:
> This is correct, but the average length of "new_scope" is small
> because it doesn't contain a full path most of the time, so we're
> basically talking about optimizing the lookup of ".dll" in strings
> like "kernel32.dll" or "libc.so.6" in a function that does a lot of
> other costly stuff... Mono hackers usually take this into account
> during coding. I'm not saying that functions like
> str_{starts|ends}_with() won't be useful, but it's usually not
> rewarding enough to touch already tested (and profiled) code. If you
> find such issues in the future, please file bugs so they don't get
> lost because the probability that some hacker will track our
> conversation and replace strstr is near zero. 
> Robert