[Mono-dev] [PATCH] Replace ENABLE_COREE with a runtime switch.

[Rodrigo Kumpera]

Does it break the verifier without mixed mode enabled? If it doesn't
looks good to me.



On Mon, Mar 7, 2011 at 9:11 PM, Vincent Povirk <madewokherd at gmail.com>wrote:

> This patch mostly reverts 666d37829304e85f72969c44e92bc11ca167a272,
> which put Mono's mixed-mode support in #ifdef ENABLE_COREE, disabling
> it by default on Windows.
>
> It was disabled because it broke the verifier, and it still does.
>
> Since most of the new behavior is dependent on whether coree has been
> hooked, or whether a particular image has been loaded using the OS
> loader, skipping the hook step effectively disables coree at runtime.
> So this patch moves that step out of mono_init_internal and into
> mono_main, where it is dependent on a runtime switch.
>
> Even if this didn't break the verifier, I think it's an intrusive,
> hacky change to how Mono loads things that almost no one needs, and so
> having it default off makes sense. Also, (my real motive) it's a step
> towards my goal of getting Wine's builtin mscoree.dll to use Mono's
> mixed-mode support without indirectly causing itself to be hooked.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20110318/a2c361e5/attachment.html