[Mono-dev] Patch to HashSet (System.Core) to enable serialization

[Nicklas Overgaard]

Hi Robert,

1) I know, I kinda created the method to ensure that everyting was
working as I expected.

2) I'll try and remove it.

And I have not verified the output against the MS.NET implementation. I
will do that on monday when I have access to a windows machine.

I will resubmit a cleaner patch next week.

/Nicklas

On Fri, 2011-01-21 at 22:46 -0500,
mono-devel-list-request at lists.ximian.com wrote:
> Date: Fri, 21 Jan 2011 13:58:11 +0100
> From: Robert Jordan <robertj at gmx.net>
> Subject: Re: [Mono-dev] Patch to HashSet (System.Core) to enable
>       serialization
> To: mono-devel-list at lists.ximian.com
> Message-ID: <ihbvsr$8aq$1 at dough.gmane.org>
> Content-Type: text/plain; charset=UTF-8; format=flowed
> 
> Hi Nicklas,
> 
> On 21.01.2011 10:35, Nicklas Overgaard wrote:
> > Hi,
> >
> > Attached is a patch that makes the HashSet class serializable.
Included
> > are unittests to check the functionality.
> 
> Thanks for the patch. There are some issues with it, though:
> 
> 1) it's not allowed to expose public members as you do
> with UnittestEqualityCheck.
> 
> 2) OnDeserialization is supposed to be called by the serialization
> infrastructure implicitly. There is no need to invoke it manually
> from the ctor.
> 
> Have you checked if the serialization format matches MS.NET?
> 
> Robert