[Mono-dev] Candidate Fix for 699643

[Neale Ferguson]

Actually, given that TdsMetaParameter is only referenced by Tds70.cs and
Tds80.cs, then is the test necessary?

If it is, what would be the best way of getting the value of tdsVersion?
Should Tds.cs constructor invoke something in TdsMetaParameter to pass it
the value for future reference? I seem to be having a senior moment trying
to work out the simplest method of performing the test.

Neale


On 11/23/11 2:14 PM, "Veerapuram Varadhan" <vvaradhan at novell.com> wrote:

> Yes, certainly
> 
> On Wed, 2011-11-23 at 14:05 -0500, Neale Ferguson wrote:
>> Understood. Will something like this help?
>> 
>> if (tdsVersion >= TdsVersion.tds70) {
>> :
>> }
>> 
>> 
>> On 11/23/11 1:54 PM, "Veerapuram Varadhan" <vvaradhan at novell.com> wrote:
>> 
>>> Hi Neale,
>>> 
>>> First part of the fix would be good to go.  The later part will have
>>> issues with earlier versions of TDS, which people still use.
>>> 
>>> V. Varadhan
>>> 
>>> On Wed, 2011-11-23 at 13:28 -0500, Neale Ferguson wrote:
>>>> I am looking to commit the following fix http://pastebin.com/qw2WdzPr to
>>>> resolve bug 699643 (https://bugzilla.novell.com/show_bug.cgi?id=699643).
>>>> Would someone be willing to review it?
>>>> 
>>>> Neale
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Mono-devel-list mailing list
>>>> Mono-devel-list at lists.ximian.com
>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>> 
>>> 
>>> 
>> 
>> 
>> 
> 
>