[Mono-dev] eglib changes for Moonlight

Chris Toshok toshok at gmail.com
Mon Apr 18 15:41:58 EDT 2011


On Mon, Apr 18, 2011 at 12:28 PM, Rodrigo Kumpera <kumpera at gmail.com> wrote:

> Some comments:
>
> garray.c : 204
> + else {
> + // MOONLIGHT_FIXME
> + // should we handle the case where they want to shrink the array? (note:
> glib doesn't)
> + }
>
> Either handle it or assert. Actually, I don't think that anything special
> must be done to handle shrink,
> not even clear_.
>

nod.  not much has to happen - i just left the fixme in because there was
stuff we might want to address.  I can remove the fixme and leave the other
comment, or remove the else branch entirely.

glib does clear the memory in gc-friendly mode, but that's all they do (and
that's the only time they do it.)


> --- a/eglib/src/gbytearray.c
> +++ b/eglib/src/gbytearray.c
>
> This code is just a cleanup so should be pushed separately, right?
>
> --- a/eglib/src/ghashtable.c
> +++ b/eglib/src/ghashtable.c
>
> This change is a fix for compatibility and not new stuff, put it in a
> separate commit.
>
>
K, I can split these out.


>
> +gunichar*
> +g_utf8_to_ucs4_fast (const gchar *str, glong len, glong *items_written)
> +{
>
> You g_malloc0 here, it doesn't make sense to zero since it will be filled
> right after.
>
>

Cool, thanks.  Fixed locally.


> On Mon, Apr 18, 2011 at 4:14 PM, Chris Toshok <toshok at gmail.com> wrote:
>
>> Attached is the patch we're currently working with wrt moonlight running
>> on eglib (needed for our coming embedded dominance, and used in the android
>> port).  Anyone care to review it?  I'd love to commit it today sometime so
>> we can move forward with merging all the rest of the moonlight changes into
>> the mainline.
>>
>> There are a couple of FIXME's in the patch, all of which will be addressed
>> pretty quickly (the exception perhaps being g_unichar_break_type - we're
>> going to need someone who knows unicode to deal with that mess).
>>
>> Thoughts, comments?
>> Chris
>>
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20110418/08085239/attachment.html 


More information about the Mono-devel-list mailing list