[Mono-dev] Mono Winforms on Mac

[Miguel de Icaza]

Hello,

    I have created a diff file from the formatted sources that removes
some of the other automatic changes that probably came out of some
refactoring tool.   The patch itself can not be used directly against
Mono's source code since it is still a diff from formatted to formatted,
not from Mono to formatted.    This means that we are going to have to
apply every patch by hand.

    I personally like the changes that were made by the tool, like
dropping the gratuitous overuse of namespaces in the Managed.Winforms
code, and would love to plug those changes back in the future.   

    In terms of how to get the changes merged, ideally, Ralph could
review the attached file and provide a roadmap of what each of the
changes do.   There are some that I suspect wont be controversial, for
example:

	* There is a refactoring of the Clipboard code, this seems 
	  straightforward, but it still needs a review.

	* Some look like simple bug fixes, but it would be good to 
	  know what were they fixing (for example the ListView.cs 
	  changes).

    There are other pieces that look like they went through a lot of
work, and a more detailed explanation of the changes would be useful, in
this group, I would include:

	* Hwnd.cs

	* XplatUICarbon.cs

    There are some that probably we can skip, like the System.Drawing
tracing facility.

     The cleaned up patch is here:

	http://tirania.org/tmp/changes.gz

     This is the diffstat.  aNot sure how to deal with this, perhaps
with a Google doc, where we can use colors to flag what is applied and
what not?   Or perhaps we remove parts of the patch when we have
manually applied that bit?

 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/ControlHandler.cs |    4 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/Cursor.cs         |   36 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/Dnd.cs            |    4 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/Enums.cs          |    6 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/MouseHandler.cs   |  111 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/Pasteboard.cs     |   65 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/Structs.cs        |   18 
 Managed.Windows.Forms/System.Windows.Forms.CarbonInternal/WindowHandler.cs  |    8 
 Managed.Windows.Forms/System.Windows.Forms.Layout/LayoutEngine.cs           |   48 
 Managed.Windows.Forms/System.Windows.Forms/Application.cs                   |    1 
 Managed.Windows.Forms/System.Windows.Forms/Clipboard.cs                     |  387 --
 Managed.Windows.Forms/System.Windows.Forms/Control.cs                       |   27 
 Managed.Windows.Forms/System.Windows.Forms/Cursor.cs                        |   30 
 Managed.Windows.Forms/System.Windows.Forms/Cursors.cs                       |   12 
 Managed.Windows.Forms/System.Windows.Forms/DataFormats.cs                   |   80 
 Managed.Windows.Forms/System.Windows.Forms/DataGrid.cs                      |    5 
 Managed.Windows.Forms/System.Windows.Forms/DataGridView.cs                  |   14 
 Managed.Windows.Forms/System.Windows.Forms/Form.cs                          |    9 
 Managed.Windows.Forms/System.Windows.Forms/Hwnd.cs                          |  340 -
 Managed.Windows.Forms/System.Windows.Forms/ImageList.cs                     |    6 
 Managed.Windows.Forms/System.Windows.Forms/ImageListStreamer.cs             |  301 -
 Managed.Windows.Forms/System.Windows.Forms/LayoutEngine.cs                  |   51 
 Managed.Windows.Forms/System.Windows.Forms/ListView.cs                      |    7 
 Managed.Windows.Forms/System.Windows.Forms/MdiWindowManager.cs              |    4 
 Managed.Windows.Forms/System.Windows.Forms/MimeIcon.cs                      |   28 
 Managed.Windows.Forms/System.Windows.Forms/PageSetupDialog.cs               |    8 
 Managed.Windows.Forms/System.Windows.Forms/RichTextBox.cs                   |    6 
 Managed.Windows.Forms/System.Windows.Forms/SplitContainer.cs                |   26 
 Managed.Windows.Forms/System.Windows.Forms/Splitter.cs                      |   40 
 Managed.Windows.Forms/System.Windows.Forms/TextBoxBase.cs                   |    3 
 Managed.Windows.Forms/System.Windows.Forms/TextControl.cs                   |   10 
 Managed.Windows.Forms/System.Windows.Forms/Theme.cs                         |    2 
 Managed.Windows.Forms/System.Windows.Forms/ToolStripRenderer.cs             |    5 
 Managed.Windows.Forms/System.Windows.Forms/Win32DnD.cs                      |   20 
 Managed.Windows.Forms/System.Windows.Forms/X11Clipboard.cs                  |    7 
 Managed.Windows.Forms/System.Windows.Forms/X11Dnd.cs                        |    8 
 Managed.Windows.Forms/System.Windows.Forms/X11Structs.cs                    |    3 
 Managed.Windows.Forms/System.Windows.Forms/XEventQueue.cs                   |   12 
 Managed.Windows.Forms/System.Windows.Forms/XplatClipboard.cs                |   83 
 Managed.Windows.Forms/System.Windows.Forms/XplatClipboardCarbon.cs          |  642 +++
 Managed.Windows.Forms/System.Windows.Forms/XplatClipboardWin32.cs           |  712 +++
 Managed.Windows.Forms/System.Windows.Forms/XplatClipboardX11.cs             |  574 ++
 Managed.Windows.Forms/System.Windows.Forms/XplatUI.cs                       |  195 -
 Managed.Windows.Forms/System.Windows.Forms/XplatUICarbon.cs                 | 1914 +++++-----
 Managed.Windows.Forms/System.Windows.Forms/XplatUIDriver.cs                 |   52 
 Managed.Windows.Forms/System.Windows.Forms/XplatUIWin32.cs                  |  642 +--
 Managed.Windows.Forms/System.Windows.Forms/XplatUIX11.cs                    |  680 +--
 System.Drawing/System.Drawing.Drawing2D/GraphicsPath.cs                     |    8 
 System.Drawing/System.Drawing/Bitmap.cs                                     |   15 
 System.Drawing/System.Drawing/Font.cs                                       |   38 
 System.Drawing/System.Drawing/Graphics.cs                                   |   13 
 System.Drawing/System.Drawing/Image.cs                                      |    8 
 System.Drawing/System.Drawing/Manifest.cs                                   |   78 
 System.Drawing/System.Drawing/ToolboxBitmapAttribute.cs                     |   14 
 System.Drawing/System.Drawing/carbonFunctions.cs                            |   94 
 55 files changed, 4741 insertions(+), 2773 deletions(-)

Miguel