[Mono-dev] Fwd: [Mono-patches] [mono/mono] [3 commits] 894b26fe: Warnings cleanup

Atsushi Eno atsushieno at veritas-vos-liberabit.com
Sat Oct 16 23:42:22 EDT 2010

  Well, it is just that I often have to leave some code that is not in 
used yet, or had to disable and then "find references" that should be 
actually used, modified, or replaced.

For example, Marek changed the code like this:

        this.root = instance;
        sctx = schemaContext;
-      this.settings = settings;
+//      this.settings = settings;

This kind of changes cause overlook where the relevant types or members 
should be supported when it is being implemented.

Or if you are asking about any "specific" "regression in this case", 
there isn't except that it simply blocked ongoing work. I don't think 
asking to not make such changes much later when I am actually faced 
problems is better though.

Atsushi Eno

On 2010/10/16 23:51, Miguel de Icaza wrote:
> Hello,
>      Can you please don't randomly make cosmetic code changes that
>     does not
>     only prevent active hacking but also removes variable/member
>     references
>     that we can find by IDEs? There are very often reason we have such
>     extra
>     code.
> Let us also take this opportunity to learn exactly what this feature 
> about variable/members that are used by IDEs is.
> What was the regression in this case Atsushi, I tried figuring it out, 
> but I could not from your short email?
> Miguel

More information about the Mono-devel-list mailing list