[Mono-dev] [RFC 10/12] eglib: Workaround hardcoded library dependencies for Haiku

[Andreas Färber]

Hey Miguel,

Am 26.03.2010 um 17:15 schrieb Miguel de Icaza:

>> A proper fix would probably be autoconf checks for those libraries.
>
> Right, which is why this patch is unacceptable.
>
> Because the burden is now on us to maintain these half-cooked patches
> and legacy code.

Note that some of the patches were marked "RFC", not "PATCH". Without  
such workarounds it's impossible to verify compilation of the good  
patches.

I'm interested in feedback on *how* to cook an acceptable solution.
Obviously the src/Makefile.am part would break pretty much all other  
platforms, it is not intended to go in like that.
The test/Makefile.am part however looks correct since the .la file  
should already contain -ldl, no?

Andreas

>
>>
>> This commit is licensed under the MIT X11 license.
>> ---
>>  eglib/src/Makefile.am  |    2 +-
>>  eglib/test/Makefile.am |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/eglib/src/Makefile.am b/eglib/src/Makefile.am
>> index 337c988..1597691 100644
>> --- a/eglib/src/Makefile.am
>> +++ b/eglib/src/Makefile.am
>> @@ -52,7 +52,7 @@ INCLUDES = -I$(srcdir)
>>  if HOST_WIN32
>>  libeglib_la_LIBADD = -lm -liconv -lpsapi
>>  else
>> -libeglib_la_LIBADD = -lm -ldl
>> +#libeglib_la_LIBADD = -lm -ldl
>>  endif
>>
>>  libeglib_static_la_LIBADD = $(libeglib_la_LIBADD)
>> diff --git a/eglib/test/Makefile.am b/eglib/test/Makefile.am
>> index 4f825b3..3411ef9 100644
>> --- a/eglib/test/Makefile.am
>> +++ b/eglib/test/Makefile.am
>> @@ -30,7 +30,7 @@ SOURCES = \
>>  test_eglib_SOURCES = $(SOURCES)
>>
>>  test_eglib_CFLAGS = -Wall -Werror -D_FORTIFY_SOURCE=2 -I$ 
>> (srcdir)/../src -I../src -DDRIVER_NAME=\"EGlib\"
>> -test_eglib_LDADD = ../src/libeglib.la -ldl
>> +test_eglib_LDADD = ../src/libeglib.la
>>
>>  run-eglib: all
>>        ./test-eglib
>> --
>> 1.6.5.3
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>