[Mono-dev] Non Aligned Nurseries

[Mark Probst]

On Fri, Mar 19, 2010 at 11:45 PM, Sanjoy Das
<sanjoy at playingwithpointers.com> wrote:
> Finally got the non-aligned nursery feature to work. Passes all the
> mscorlib checks except 'MonoTests.System.StringTest.Intern ()', which
> SGen fails even when ALIGN_NURSERY is defined. Patch attached.

Thanks for the patch!

Please take out the first hunk - we already have way too many
uncommented #defines for testing in sgen-gc.c.

Don't dereference ptr twice - do it once and store the result in a local.

I'm curious: Why are you comparing with GT against nursery_start-1
when you could compare with GE against nursery_start?

Also, unless you have a good reason, you should use short-circuit
evaluation, i.e. instead of

  a b cgt
  d e clt
  and
  brtrue exit
 continue:

do

  a b ble continue
  d e bge continue
  br exit
 continue:

Mark

-- 
Mark Probst
  http://www.complang.tuwien.ac.at/schani/
  http://www.flickr.com/photos/schani/
  http://schani.wordpress.com/