[Mono-dev] Patch 2/2 - Tests for System.Diagnostics.Contracts in corlib

[Chris Bacon]

Hi,

Updated patch attached. I've checked that all tests still pass.

The delegate has been removed, and #if NET_4_0 now surrounds the whole 
of each file.

However, the #defines are not un-defined at the end of each file, as I 
don't think this is possible in C#, as all #define and #undef statements 
have to be before any code. Please let me know if there is a way of 
#undef-ing another way.

Thanks
Chris

Marek Safar wrote:
> Hello Chris,
>
> Only a few small issues
>
> +#define CONTRACTS_FULL
> +#define DEBUG
> +
>
> Undefined these at the end of each file. They perhaps should be inside 
> #if NET_4_0 too.
>
> +        // Required when compiling/running under .NET3.5
> +        delegate void Action<T1, T2, T3, T4, T5> (T1 arg1, T2 arg2, 
> T3 arg3, T4 arg4, T5 arg5);
> +
>
> Why is it needed when NET_4_0 is used for whole file ?
>
> When fixed please commit. Thanks!
>
> Marek
>
>> Hi,
>> I've attached a new patch with slightly better formatting - it uses 
>> tabs rather than spaces.
>> Kind regards
>> Chris
>>
>> Chris Bacon wrote:
>>> Hi,
>>>
>>> Here are the tests to add to corlib for System.Diagnostics.Contracts.
>>>
>>> Please let me know what changes are required.
>>>
>>> Kind regards
>>> Chris
>>> ------------------------------------------------------------------------ 
>>>
>>>
>>> _______________________________________________
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: CodeContractsTest.patch
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100623/ce083120/attachment-0001.pl