[Mono-dev] [PATCHES] Bug 480178 - System.Globalization.CharUnicodeInfo.GetUnicodeCategory() does not handle surrogate characters appropriately.

[Atsushi Eno]

Hello,

I keep silent as it's rather about runtime issue, but since there is no 
one giving further comments on the bug, I think no one can complain if 
it got checked in svn.

Damien, thanks for the patch.

Atsushi Eno


On 2010/06/11 23:36, Damien Diederen wrote:
> Hello,
>
> Has anybody had a look at these patches?
>
> I'm (obviously) still open to comments, but I would be perfectly happy
> to learn that it is deemed acceptable—and that somebody with the commit
> bit will take care of integrating it :)
>
> (No hurry; this is just a “ping”).
>
> Cheers,
> Damien
>
> Damien Diederen<dd at crosstwine.com>  writes:
>    
>> Hi Miguel,
>>
>> I finally had an opportunity to look into this, and just uploaded v5 of
>> this series:
>>
>>    - The non-BMP portions of the tables are omitted when the
>>      preprocessor symbol DISABLE_ASTRAL is defined;
>>
>>    - The runtime now supports two sets of tables, one for 2.0–3.5 and
>>      one for 4.0.  This second set can be omitted by defining
>>      DISABLE_NET_4_0.
>>
>> Cf. https://bugzilla.novell.com/show_bug.cgi?id=480178#c42&  following.
>>
>> Cheers, -D
>>
>> Miguel de Icaza<miguel at novell.com>  writes:
>>      
>>>> That can certainly be done.  I suppose you envision a compile-time
>>>> switch?  Is there already such an option/flag/preprocessor symbol I
>>>> should use as a model?
>>>>          
>>> For C code, just use the symbol DISABLE_ASTRAL, then we can add that to
>>> configure.in
>>>
>>>        
>>>> Sure.  I guess this means some more compile-time conditionalization of
>>>> the runtime; corlib can just pass a version parameter at class init time
>>>> as in v3 of my patches:
>>>>
>>>> #if NET_4_0
>>>> 		private const int CategoryDataVersion = 4;
>>>> #else
>>>> 		private const int CategoryDataVersion = 2;
>>>> #endif
>>>>          
>>> Exactly right;
>>> Miguel
>>>        
>