[Mono-dev] Patch 2/2 - Tests for System.Diagnostics.Contracts in corlib

Marek Safar marek.safar at seznam.cz
Fri Jun 18 06:20:13 EDT 2010


Hello Chris,

Only a few small issues

+#define CONTRACTS_FULL
+#define DEBUG
+

Undefined these at the end of each file. They perhaps should be inside 
#if NET_4_0 too.

+        // Required when compiling/running under .NET3.5
+        delegate void Action<T1, T2, T3, T4, T5> (T1 arg1, T2 arg2, T3 
arg3, T4 arg4, T5 arg5);
+

Why is it needed when NET_4_0 is used for whole file ?

When fixed please commit. Thanks!

Marek

> Hi,
> I've attached a new patch with slightly better formatting - it uses 
> tabs rather than spaces.
> Kind regards
> Chris
>
> Chris Bacon wrote:
>> Hi,
>>
>> Here are the tests to add to corlib for System.Diagnostics.Contracts.
>>
>> Please let me know what changes are required.
>>
>> Kind regards
>> Chris
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> ------------------------------------------------------------------------
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list



More information about the Mono-devel-list mailing list