[Mono-dev] Patch for CookieContainer.SetCookies

[Tom Philpot]

On Jan 20, 2010, at 1:58 PM, Sebastien Pouliot wrote:


why not simply
c.HttpOnly = cookie.HttpOnly;
c.Secure = cookie.Secure;
?

if there's a problem with this simpler code then it does not get caught
by your new unit tests.


I had thought I saw code like the following in Cookie.cs (for Secure and HttpOnly) at one point.
public bool Secure
{
get { return secure; }
set { secure = true; }
}

Je fumais la moquette.


I suspect the "expires" case is the buggy one wrt your unit test
(previous email).

Sebastien


The expires test case worked perfectly if you're on the Pacific Time Zone ;). It should be fixed in this patch.

I believe I've followed the coding conventions, but I'm not quite sure about the long Regex's in CookieContainer.cs.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100120/55a195a7/attachment-0001.html 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: CookieContainer_Patch.txt
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100120/55a195a7/attachment-0002.txt 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100120/55a195a7/attachment-0002.htm 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: CookieContainerTest_Patch.txt
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100120/55a195a7/attachment-0003.txt 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100120/55a195a7/attachment-0003.htm