[Mono-dev] simd version patch

[Rodrigo Kumpera]

The changes in mini.h / mini-x86.c / mini-amd64.c are not needed. They make
no difference at all.

Are you sure that all those intrinsics are not supported by neon? It would
be better to first check if
the changes are needed first.

The change to the SimdIntrinsc struct increase it's size by 7 bytes, with is
quite significant given
its current size is 6. We can change it to be something like:

typedef struct {
guint16 name;
guint16 opcode;
guint8 simd_version;
guint8 simd_emit_mode : 4;
guint8 flags : 4;
} SimdIntrinsc;

Which keeps its size the same and gives space for a NEON bit. In case we
need more bits, we
just switch to a hybrid 3 bits sse level + 5 boolean bits. Your patch is
really not acceptable since
it required 3 bytes align padding between simd_emit_mode
and simd_version_flags.



On Sat, Jan 16, 2010 at 6:38 PM, Jerry Maine - KF5ADY <crashfourit at gmail.com
> wrote:

> Here is a patch to update the runtime simd version tests so that it
> would be easier and less hackish to implement ports beyond x86/amd64
> (like arm and altavic).
>
> Comments? Questions?
>
> Jerry
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100116/ada2e9f5/attachment.html