[Mono-dev] [patch] VBCodeGenerator generic arguments

Rolf Bjarne Kvinge rolflists at ya.com
Mon Aug 9 05:31:33 EDT 2010


A couple of comments: You refactor some code into another method
(DetermineTypeOutput), which shouldn't be in the same patch as the other
changes (i.e. one patch for the support for generic arguments, then another
patch for the refactoring). A few tests covering the change would also be
nice :) Otherwise it looks good.


>From: mono-devel-list-bounces at lists.ximian.com
[mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Alex Corrado
>Sent: domingo, 08 de agosto de 2010 3:53
>To: mono-devel-list at ximian.com
>Subject: [Mono-dev] [patch] VBCodeGenerator generic arguments
>Hi all,
>I'm working on a Codedom-based C++ wrapper generator, and I discovered that
mono's vb code generator doesn't output generic type arguments in some
>Attached is a patch to implement that. Most of it is just copied from
CSharpCodeGenerator.cs, modified for vb's syntax, of course.
>Comments appreciated :)
>-Alex Corrado
>alexander.corrado at gmail.com

More information about the Mono-devel-list mailing list