[Mono-dev] fixing some warnings - fatal error call might return

Miguel de Icaza miguel at novell.com
Fri Aug 6 17:24:41 EDT 2010


Hello Alexander,

    I like the patch, but it would be best if you included ChangeLog
entries that detail the changes.

> found a location in fatal error area where compiler complained about a function returning whilst it should not return. in fact it was dependent on a variable that could be set to anything.
> 
> imagine a problem damages some data including the conditional value and then faults for whatever reason - the thread would be able to return into the application code and possibly causing further data corruption including e.g. some data on file systems.
> 
> more trivia fixes and enlightening comments are included in the attached patch.
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list




More information about the Mono-devel-list mailing list