[Mono-dev] [PATCH] Android Support [3/4]

[Andreas Färber]

Am 20.04.2010 um 11:16 schrieb Paolo Molaro:

> On 04/19/10 Jonathan Pryor wrote:
>> Index: mono/mini/exceptions-arm.c
>> ===================================================================
>> --- mono/mini/exceptions-arm.c	(revision 155735)
>> +++ mono/mini/exceptions-arm.c	(working copy)
>> @@ -12,7 +12,11 @@
>> #include <glib.h>
>> #include <signal.h>
>> #include <string.h>
>> +#if defined(PLATFORM_ANDROID)
>> +#include <asm/sigcontext.h>
>> +#else
>> #include <ucontext.h>
>> +#endif
>
> Please make sure configure has the appropriate header checks and use:
>
> #ifdef HAVE_ASM_SIGCONTEXT_H
> #include <asm/sigcontext.h>
> #endif
> #ifdef HAVE_UCONTEXT_H
> #include <ucontext.h>
> #endif
>
> We must use feature checks and not platform checks as much as  
> possible.

+1. ucontext.h was dropped in POSIX.1-2008, so this is not just about  
Android.

Andreas