[Mono-dev] [PATCH] Android Support [1/4]

[Jonathan Pryor]

On Mon, 2010-04-19 at 14:26 -0400, Jonathan Pryor wrote:
> On Mon, 2010-04-19 at 15:15 -0300, Rodrigo Kumpera wrote:
> > +static void 
> > +out_vfprintf (FILE *ignore, const gchar *format, va_list args)
> > +{
> > + __android_log_vprint (ANDROID_LOG_ERROR, "mono", format, args);
> > +}
> > 
> > Shouldn't we identify the entry by the application name instead of
> > mono?
> 
> In an ideal world, yes, but I'm not sure how to do that.  I suppose
> using g_get_application_name() would be THE way, except that Mono
> doesn't currently call g_set_application_name() (and eglib doesn't
> implement either), so that would appear to be a more invasive change for
> the mono-2-6 branch.

Added a TODO comment noting that a better name should be used.

Committed to mono-2-6 (r155762) and trunk (r155763).

Thanks!
 - Jon