[Mono-dev] [PATCH] Mono and the MOSA Project

[Phil Garcia]

On Fri, Apr 9, 2010 at 7:44 AM, Paolo Molaro <lupus at ximian.com> wrote:

> I don't think that shuffling around the code like that is acceptable for
> us. A change that could be included would be to surround the icalls
> with a #if check and then you compile with that define.
> I suggest something like NO_ICALLS.
>

We originally tried that approached by surrounding the internal call
declarations with #if and #endif and around the new "partial" keyword in to
the class definition. But based on some feedback from Miguel that
"#ifdef are a mess" (he preferred partial classes instead) and similar
discussions within the MOSA team, we abandoned that approach in favor of
using partial classes for separating the internal calls. With the
proposed approach, the source code is less cluttered since conditional
compiler directives are not needed. One beneficial side effect is we can
automated more with less manual edits too.

We are open to either approach, but prefer the one proposed.

Phil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100409/37b597d2/attachment-0001.html