[Mono-dev] Include pthread.h in mono/utils/gc_wrapper.h and kill bash in web/mono-build.sh

[Andreas Färber]

Hi,

Am 04.04.2010 um 15:03 schrieb Robert Nagy:

> Index: mono/utils/gc_wrapper.h
> ===================================================================
> --- mono/utils/gc_wrapper.h     (revision 154762)
> +++ mono/utils/gc_wrapper.h     (working copy)
> @@ -33,6 +33,14 @@
> #       endif
> #      endif
>
> +       /*
> +        * In the case of multithreaded code, gc.h should be included
> +        * after the threads header file, and after defining  
> GC_THREADS.
> +        */
> +#      if defined(HAVE_PTHREAD_H)
> +#      include <pthread.h>
> +#      endif
> +#      define GC_THREADS

I doubt this define is right here... configure.in should take care of  
such defines, and the Windows platforms were the only ones to define  
GC_THREADS. There's more specific defines like GC_OPENBSD_THREADS  
iirc, at least in upstream bdwgc CVS.

> #      ifdef HAVE_GC_GC_H
> #              include <gc/gc.h>
> #              include <gc/gc_typed.h>
> Index: web/mono-build.sh
> ===================================================================
> --- web/mono-build.sh   (revision 154762)
> +++ web/mono-build.sh   (working copy)
> @@ -1,4 +1,4 @@
> -#! /usr/bin/env bash
> +#!/bin/sh
>
> # Script to automate the building of mono and its dependencies.
> # Relies on wget being installed (could make it fall back to using

I'd ask to not mix this in, please.

Andreas