[Mono-dev] [Mono-patches] r144627 - in trunk/mcs/class/corlib: System.Threading Test/System.Threading

[Gonzalo Paniagua Javier]

On Thu, 2009-10-22 at 09:53 -0400, Sebastien Pouliot wrote:
> On Thu, 2009-10-22 at 11:38 -0200, Rodrigo Kumpera wrote:
> > Hey Sebastien,
> > 
> > If a given test doesn't work under MS, please don't mark it as
> > "NotWorking" since this is used to flag problems
> > on mono's side and not on the test itself.
> 
> The ChangeLog may be a bit confusing but if you look at the patch itself
> you'll see that the test was modified (so it does not fail on MS
> anymore) *and* marked as NotWorking (since this is a now problem on mono
> side).
> 
> > If the test is bogus just remove it, no need carry such junk forward.
> 
> It's not bogus, nor junk. The fix is simple but don't want to apply it
> before talking to Gonzalo about it (who wrote the original test) since I
> don't know if some of our code depends on this behavior.

Calling Monitor.Exit on an object on which Monitor.Enter wasn't called
didn't fail in MS 1.x and does fail since MS 2.0. Mono's behavior
matches MS 1.x. Loooong time ago, I thought of fixing it (the fix is
trivial), but that could wreak havoc in a few areas of the class
libraries that I know of and possible more that I don't know about.

Perhaps now that we're deprecating 1.x in trunk it's time to fix this.

-Gonzalo