[Mono-dev] [Mono-patches] r144627 - in trunk/mcs/class/corlib: System.Threading Test/System.Threading

[Sebastien Pouliot]

On Thu, 2009-10-22 at 11:38 -0200, Rodrigo Kumpera wrote:
> Hey Sebastien,
> 
> If a given test doesn't work under MS, please don't mark it as
> "NotWorking" since this is used to flag problems
> on mono's side and not on the test itself.

The ChangeLog may be a bit confusing but if you look at the patch itself
you'll see that the test was modified (so it does not fail on MS
anymore) *and* marked as NotWorking (since this is a now problem on mono
side).

> If the test is bogus just remove it, no need carry such junk forward.

It's not bogus, nor junk. The fix is simple but don't want to apply it
before talking to Gonzalo about it (who wrote the original test) since I
don't know if some of our code depends on this behavior.

> Rodrigo
> 
> On Thu, Oct 22, 2009 at 9:51 AM, Sebastien Pouliot
> (sebastien at ximian.com) <mono-patches-list at lists.ximian.com> wrote:
>         Author: spouliot
>         Date: 2009-10-22 07:51:31 -0400 (Thu, 22 Oct 2009)
>         New Revision: 144627
>         
>         Modified:
>           trunk/mcs/class/corlib/System.Threading/ChangeLog
>           trunk/mcs/class/corlib/System.Threading/Monitor.cs
>           trunk/mcs/class/corlib/Test/System.Threading/ChangeLog
>           trunk/mcs/class/corlib/Test/System.Threading/MonitorTest.cs
>         Log:
>         In System.Threading:
>         2009-10-22  Sebastien Pouliot  <sebastien at ximian.com>
>         
>                * Monitor.cs: Fix validations for TryEnter and Wait.
>         Reduce
>                duplicated code between overloads.
>         
>         In Test/System.Threading:
>         2009-10-22  Sebastien Pouliot  <sebastien at ximian.com>
>         
>                * MonitorTest.cs: Mark existing tests as "NotWorking"
>         since they
>                fail in MS FX2 (maybe they worked in 1.x?). Add more
>         test cases
>                to validate the TryEnter and Wait overloaded methods.
>