[Mono-dev] Patch for XmlConvert and System.ServiceModel.Syndication

[Atsushi Eno]

Actually I applied your Atom10FeedFormatter change too. The constructor 
argument to
Atom10ItemFormatter is only for writing, not for reading. Then your 
patch turned out to
be correct in conclusion.

Atsushi Eno

On 2009/10/05 14:46, Atsushi Eno wrote:
> Hi,
>
> Thanks for the patches. I have applied XmlConvert and
> Atom10ItemFormatter changes
> in trunk, but not for Atom10FeedFormatter change. It will cause other
> kind of regressions.
> I'll find another fix and backport them to 2.6.
>
> Atsushi Eno
>
> On 2009/10/03 6:17, David Mitchell wrote:
>    
>> I would very much appreciate it if someone would review/apply this
>> patch. Apologies for being too lazy to write a test case (the changes
>> /are/ pretty simple).
>>
>> Here’s what you’ll find:
>> - Calling XmlConvert.ToDateTimeOffset (all overloads) no longer
>> results in a stack overflow. Moreover, the return value should
>> actually be correct.
>> - Atom10ItemFormatter now uses XmlConvert.ToDateTimeOffset to parse
>> the publish date and last updated time.
>> - Atom10FeedFormatter’s ReadItem returns real values (specifying a
>> SyndicationItem in the constructor for Atom10ItemFormatter doesn’t
>> work right now: it eventually gets overwritten with a new value).
>>
>> Thanks!
>> --Dave
>>
>>
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>
>>      
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
>
>