[Mono-dev] [patch] coreclr/com check + icall cleanup

[Rodrigo Kumpera]

The icall removal patch is ok.

The second one is tricky. Do we really want to completely disable COM
support when running under the sandbox?
It does make sense for moonlight, but not for other users of coreclr.

I believe we should only fail COM for non-platform assemblies which has the
same result for moonlight but won't
bite future users of the sandbox code.



On Thu, Oct 29, 2009 at 4:43 PM, Sebastien Pouliot <sebastien at ximian.com>wrote:

> Hello,
>
> Two small/easy patches for review.
>
> The first one avoid calling mono_com_init when coreclr is enabled*.
> This avoid a crash if some assembly use [ComImport] on a type and throw
> a TypeLoadException - which is what happens in Silverlight.
>
>        * For some reason (I guess it use COM for it's platform code,
>        while Moonlight does not) Silverlight expose [ComImport] but
>        otherwise does not support COM (as least for application code).
>
> Second patch removes some internal calls (all strings except one) that
> are not used (anymore) in the class libraries.
>
> Sebastien
>
> p.s. both patches were created from 2-6 branch but I'll commit them
> against HEAD too.
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20091104/d77c2b1b/attachment.html