[Mono-dev] [PATCH] Implement mono_thread_get_stack_bounds on windows

[Kornél Pál]

Hi,

Nice patch.

You should use DWORD_PTR instad of DWORD and DWORD64 that would unifiy 
32-bit and 64-bit parts.

I also believe that you mean "widely known" instead of "wildly know" in 
the ChangeLog.

Kornél

Rodrigo Kumpera wrote:
> And, of course, I forgot to attach the patch.
> 
> On Wed, May 20, 2009 at 7:31 PM, Rodrigo Kumpera <kumpera at gmail.com 
> <mailto:kumpera at gmail.com>> wrote:
> 
>     Forgot to mention that there is another well know hack to discover
>     stack bounds and why I rather like this one.
> 
>     The hack is to use VirtualQuery on %esp and expand the range to
>     upward regions.
> 
>     I think the VirtualQuery hack is worse as it works by using a
>     somewhat ok heuristics and OTOH the NtCurrentTe
>     one provides precise information and I doubt it will disapear overnight.
> 
> 
> 
> 
>     On Wed, May 20, 2009 at 7:25 PM, Rodrigo Kumpera <kumpera at gmail.com
>     <mailto:kumpera at gmail.com>> wrote:
> 
>         Hey,
> 
>         Attached is a patch that implements this function on windows.
>         Tested only on XP/win32.
> 
>         Cheers,
>         Rodrigo
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list