[Mono-dev] VB Msgbox Patch

Rolf Bjarne Kvinge rolflists at ya.com
Wed May 20 05:53:15 EDT 2009


> I looked at the patch and it looks like a reasonable fix. It would be
> perfect if you could implement a simple NUnit test that verifies the
> new (correct) behavior. 

I was about to say the same until I realized a unit test would actually put
up a message box (and unless there's somebody there to dismiss it, the test
will fail, which breaks automated testing).

So I'll give it a quick manual test, and if nothing is wrong, I'll commit
later today.

Thanks for the patch!


There was a "How to write a test" somewhere
> but I can't find it right now.  And also make sure to run all other
> unit tests as well so we know that nothing is broken. (I doubt that
> your patch could break anything but it's better to have run the tests
> than not ;-)

I as

> Happy Hacking,
> Stefan
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

More information about the Mono-devel-list mailing list