[Mono-dev] Trivial patch for xbuild

[Jonathan Chambers]

Dave,
This looks good to me for now (until we support vcproj, if ever). I'll try
and commit a variant of this with a warning to the console probably.

Thanks,
Jonathan

On Thu, May 14, 2009 at 12:35 PM, David Mitchell <dmitchell at logos.com>wrote:

> Does anyone have any feedback on this? Should I be submitting it elsewhere?
>
> --Dave
>
>
> On 5/12/09 4:39 PM, "David Mitchell" <dmitchell at logos.com> wrote:
>
> > Below is a small patch for xbuild that causes vcproj files to be ignored.
> > Unless I'm missing out on some huge secret, vcproj files aren't actually
> valid
> > msbuild project files anyway, so ignoring them should do no harm (and
> will do
> > a lot of good in the case of solutions that contain both csproj and
> vcproj
> > files--provided that the csproj files have no dependencies on the vcproj
> > files).
> >
> > I would appreciate it very much if someone would review/apply this patch.
> It
> > is blocking my organization's adoption of xbuild as our build tool on
> > Unix-based systems.
> >
> > I'm providing this patch under the same license as xbuild itself.
> >
> > --Dave
> >
> > Index: SolutionParser.cs
> > ===================================================================
> > --- SolutionParser.cs    (revision 134016)
> > +++ SolutionParser.cs    (working copy)
> > @@ -100,6 +100,12 @@
> >
> >              Match m = projectRegex.Match (line);
> >              while (m.Success) {
> > +                if (m.Groups[3].Value.EndsWith(".vcproj")) {
> > +                    // Ignore C++ projects
> > +                    m = m.NextMatch ();
> > +                    continue;
> > +                }
> > +
> >                  ProjectInfo projectInfo = new ProjectInfo
> (m.Groups[2].Value,
> > m.Groups[3].Value);
> >                  if (String.Compare (m.Groups [1].Value,
> solutionFolderGuid,
> >                          StringComparison.InvariantCultureIgnoreCase) ==
> 0) {
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090514/1a7d7d60/attachment-0001.html