[Mono-dev] [PATCH] Don't wait for finalizer thread in mono_gc_init

[Rodrigo Kumpera]

I've done quite some testing and it looks good. Please commit.

Thanks,
Rodrigo



2009/5/9 Kornél Pál <kornelpal at gmail.com>

> Hi,
>
> This is a quite small patch removing the wait form mono_gc_init by
> modifying mono_thread_create_internal to return the MonoThread object.
>
> Getting rid of the wait is required for support loading the runtime from
> DLL initialization code on Windows because DLL load and initialization is
> protected by the same lock as thread creation so this lock always results in
> a deadlock.
>
> Removing this wait on other platform should make startup faster.
>
> I was unable to reproduce any deadlock resulting from this wait, I only was
> able to reproduce a socket accept deadlock (Windows-only bug) that was
> discussed on the list earlier and is not related to this wait.
>
> I belive that this patch should eliminate the deadlock that the removed
> wait is intended to prevent. If you still are able to reproduce the
> deadlock, please attach exact stack trace for deadlocked threads and I'll
> try solve the issue.
>
> Please review the patch and if you like it please approve it.
>
> Kornél
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090511/aadbd411/attachment.html