[Mono-dev] [PATCH] Changes for CreateThread calls.

[Zoltan Varga]

Hi,

  That looks ok.

          Zoltan

On Fri, Mar 27, 2009 at 9:29 PM, Bill Holmes <billholmes54 at gmail.com> wrote:

> Hi,
>
> That fix does not work with the MSVC builds.  That attached patch is
> one way to fix it.
>
> thanks
> -bill
>
> On Fri, Mar 27, 2009 at 9:36 AM, Zoltan Varga <vargaz at gmail.com> wrote:
> > Hi,
> >
> >  This is now fixed in r130385 by adding a new 'mono_create_thread' helper
> > function.
> >
> >                  Zoltan
> >
> > 2009/3/25 Bill Holmes <billholmes54 at gmail.com>
> >>
> >> Hi,
> >>
> >> The attached patch fixes some problems I was seeing with thread IDs on
> >> Winx64.
> >>
> >> What I found was that the thread ID argument of CreateThread is a
> >> ulong which is not 64 bits on Winx64.  So when called with the address
> >> of a size variable the top 32 bits are garbage.  This patch simply
> >> initializes all thread ID variables to zero before calling
> >> CreateThread.  Is there a better way to fix this?
> >>
> >> -bill
> >>
> >>
> >>
> >> 2009-03-25  Bill Holmes  <billholmes54 at gmail.com>
> >>
> >>        * appdomain.c (mono_domain_unload),
> >>        * attach.c (transport_start_receive),
> >>        * threads.c (mono_thread_create_internal),
> >>        * threads.c (ves_icall_System_Threading_Thread_Thread_internal):
> >>          Initialize the tid variable to 0 before calls to CreateThread.
> >>          This is needed for Winx64 because that argument is only 32
> bits.
> >>
> >>        Code is contributed under MIT/X11 license.
> >>
> >> _______________________________________________
> >> Mono-devel-list mailing list
> >> Mono-devel-list at lists.ximian.com
> >> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> >>
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090328/5e4757d6/attachment.html