[Mono-dev] [PATCH] Allows cominterop_ccw_queryinterface to find interfaces implemented by base classes.

Tom Hindle tom_hindle at sil.org
Thu Jun 4 11:01:00 EDT 2009


Bill,

On Wed, 2009-06-03 at 18:13 -0400, Bill Holmes wrote:
> Tom,
> 
> Can you test the attached patch against your code?  You patch worked
> just fine, but I did not want to add the
> mono_class_get_all_implemented_interfaces to class.c.
> 
> Please let me know if this works for you.
It works.

My testing suggests it works fine for me, in that my C++ code that was
failing because of the bug still works with your patch applied, instead
of mine. (more efficient than my proposed patch as well! :) )

Thanks
Tom

> 
> -bill
> 
> On Wed, Apr 29, 2009 at 7:20 PM, Tom Hindle <tom_hindle at sil.org> wrote:
> > Hi,
> >
> > Could someone review this patch?
> >
> > Patch attached to following:
> >
> > https://bugzilla.novell.com/show_bug.cgi?id=499566
> >
> > Given this is a potential frequently called function would it be worth
> > doing either of the following optimizations?
> >
> > 1. Don't look looking for interfaces on Object class.
> > 2. Cache the results of the function, eg a map of <classname, array of
> > all implemented interfaces>
> >
> > Thanks
> > Tom
> >
> >
> >
> >
> > _______________________________________________
> > Mono-devel-list mailing list
> > Mono-devel-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
> >



More information about the Mono-devel-list mailing list