[Mono-dev] [Mono-patches] r137594 - trunk/mcs/class/System.XML/Test/System.Xml.Schema

[Atsushi Eno]

Hi Gert,

OK, you are partly right. The tests were intended to verify both
behaviors. It was just that it had extra check that are not
verified to work, as you fixed the tests themselves a few hours ago.

Atsushi Eno

Gert Driesen wrote:
> Hi Atsushi,
> 
> That's not correct. These tests verify our default behavior, or the behavior
> when the Mono is configured for strict MS compliance (if the corresponding
> environment variable is set).
> 
> Gert
> 
> 
> -----Original Message-----
> From: Atsushi Eno [mailto:atsushi at ximian.com] 
> Sent: donderdag 9 juli 2009 7:16
> To: Gert Driesen
> Cc: mono-devel-list at ximian.com
> Subject: Re: [Mono-patches] r137594 -
> trunk/mcs/class/System.XML/Test/System.Xml.Schema
> 
> As it is written in *your* comment it can be run only when certain
> environment variable is on. We don't. It has been messing our
> monobuild as showing *regression* and our QA guys have asked us to
> handle it.
> 
> Atsushi Eno
> 
> Gert Driesen wrote:
>> Hey Atsushi,
>>
>> I fixed the tests, but couldn't find your comment on bugzilla (other than
>> your comment that the test is not worth for normal users).
>> The failure for ExtensionRedefineAttribute1 may be related to bug #506122
>> (but I still should have ensured it passed, my wrong), as we currently
> allow
>> validation against a schema that failed to compile (or is this by
> design?).
>> Gert
>>
>> -----Original Message-----
>> From: mono-patches-bounces at lists.ximian.com
>> [mailto:mono-patches-bounces at lists.ximian.com] On Behalf Of Atsushi
> Enomoto
>> (atsushi at ximian.com)
>> Sent: donderdag 9 juli 2009 6:07
>> To: mono-patches at lists.ximian.com; ximian.monolist at gmail.com;
>> mono-svn-patches-garchive-20758 at googlegroups.com
>> Subject: [Mono-patches] r137594 -
>> trunk/mcs/class/System.XML/Test/System.Xml.Schema
>>
>> Author: atsushi
>> Date: 2009-07-09 00:06:41 -0400 (Thu, 09 Jul 2009)
>> New Revision: 137594
>>
>> Modified:
>>    trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog
>>    trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaTests.cs
>> Log:
>> 2009-07-09  Atsushi Enomoto  <atsushi at ximian.com>
>>
>> 	* XmlSchemaTests.cs : disabled wrong tests. I will revert them
>> 	  unless it gets better shape.
>>
>>
>>
>> Modified: trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog
>> ===================================================================
>> --- trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog
> 2009-07-09
>> 02:37:23 UTC (rev 137593)
>> +++ trunk/mcs/class/System.XML/Test/System.Xml.Schema/ChangeLog
> 2009-07-09
>> 04:06:41 UTC (rev 137594)
>> @@ -1,3 +1,8 @@
>> +2009-07-09  Atsushi Enomoto  <atsushi at ximian.com>
>> +
>> +	* XmlSchemaTests.cs : disabled wrong tests. I will revert them
>> +	  unless it gets better shape.
>> +
>>  2009-06-23  Atsushi Enomoto  <atsushi at ximian.com>
>>  
>>  	* XmlSchemaAssertion.cs, XmlSchemaTests.cs : migrate from Assertion
>>
>> Modified:
>> trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaTests.cs
>> ===================================================================
>> --- trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaTests.cs
>> 2009-07-09 02:37:23 UTC (rev 137593)
>> +++ trunk/mcs/class/System.XML/Test/System.Xml.Schema/XmlSchemaTests.cs
>> 2009-07-09 04:06:41 UTC (rev 137594)
>> @@ -423,6 +423,7 @@
>>  		}
>>  
>>  		[Test] // bug #502115
>> +		[Ignore ("wrong test as commented on bugzilla")]
>>  		public void ExtensionRedefineAttribute1 ()
>>  		{
>>  			const string xml = "<Bar xmlns='foo'/>";
>> @@ -504,6 +505,7 @@
>>  		}
>>  
>>  		[Test] // bug #502115
>> +		[Ignore ("wrong test as commented on bugzilla")]
>>  		public void ExtensionRedefineAttribute3 ()
>>  		{
>>  			const string xml = "<Bar xmlns='foo'/>";
>>
>> _______________________________________________
>> Mono-patches maillist  -  Mono-patches at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-patches
>>
>> No virus found in this incoming message.
>> Checked by AVG - www.avg.com 
>> Version: 8.5.285 / Virus Database: 270.13.5/2220 - Release Date: 07/05/09
>> 17:54:00
>>
>>
> 
> 
> No virus found in this incoming message.
> Checked by AVG - www.avg.com 
> Version: 8.5.285 / Virus Database: 270.13.5/2220 - Release Date: 07/05/09
> 17:54:00
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 
> 
>